prevents multi-touch issue on ipad #1756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iangilman
reviewed
Dec 18, 2019
| @@ -2959,7 +2959,7 @@ | |||
| } | |||
|
|
|||
| // OS-specific gestures (e.g. swipe up with four fingers in iPadOS 13) | |||
| if (gPoints[ 0 ].type === "touch" && typeof gPoints[ 0 ].currentPos === "undefined") { | |||
| if (typeof gPoints[ 0 ].currentPos === "undefined") { | |||
There was a problem hiding this comment.
Interesting. Out of curiosity, what is the type in this situation?
Also, should it really be the string "undefined", or the value undefined?
There was a problem hiding this comment.
I saw 'pen' type after very many attempts. Maybe false palm rejection with pen inputs can cause that.
That's value undefined (with typeof) :)
There was a problem hiding this comment.
Okay, good to know, regarding the pen type.
And sure enough, it's a typeof... don't know why I didn't notice that before!
|
Looking good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
iPad gestures with pen input can raise error even after #1754. This PR fix it.