Allow silencing multi-image warnings #2120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @iangilman and @msalsbery since I can't change the reviewers manually! |
iangilman
approved these changes
Mar 4, 2022
There was a problem hiding this comment.
I appreciate this patch, though I'm a little ambivalent about it: You don't really need it for your scenario... You can just call those functions on viewer.world.getItemAt(0) instead of on viewer.viewport. That said, if this works better for you, it's not harming the API, since it's an explicit flag. So, let's do it :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our application, we're overlaying multiple images on top of one another with the same dimensions. As a result, the multi-image warnings do not apply to us, and we'd like a way to silence these
console.errorcalls so our Chrome devtools aren't filled with errors.To implement this, I added a new option to
openseadragon.jsandviewport.jscalledsilenceMultiImageWarnings, and then updated each warning callsite to first check that flag.