Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2264: Navigator display rectangle is off when the page has box-sizing: border-box #2276

Merged
merged 1 commit into from Jan 20, 2023

Conversation

ambujsahu81
Copy link
Contributor

What is the PR `for?

  • should fix #2264.
  • Adds box-sizing: content-box property to the navigator display region.

Copy link
Member

@iangilman iangilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic! Thank you for making this change :)

@iangilman iangilman merged commit 5a8e7dd into openseadragon:master Jan 20, 2023
iangilman added a commit that referenced this pull request Jan 20, 2023
@ambujsahu81 ambujsahu81 deleted the patch-1 branch January 21, 2023 05:02
@joedf
Copy link
Contributor

joedf commented Jan 22, 2023

Wow, good catch! I think I've noticed this issue in the past, but didn't look into it too much and didn't figure it out.

msalsbery added a commit that referenced this pull request Feb 1, 2023
* master: (276 commits)
  Changelog for #2280 and #2238
  remove trailing space
  fix problem with click precision on ReferenceStrip
  Changelog for #2273
  Also add documentation for tileRetryDelay
  try fix with check for null and undefined
  fix build error
  Add tileRetryMax documentation.
  Revert async support and event breaking support in EventSource.
  Changelog for #2276
  add box-sizing property to the navigator display region
  Implement support for async function and promise type recognition with $.type. Add $.Promise proxy. Implement support for promises in EventSource. Implement ability to abort events as well as prioritize events.
  Changelog for #2270
  issues/2192 fix.
  Starting 4.0.1
  Version 4.0.0
  JSDoc fixes
  Changelog for #2256
  Changelog for #2249
  removed polling vs resizeviewer option from demo
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Navigator display rectangle is off when the page has box-sizing: border-box
3 participants