Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Travis to use latest Node LTS #2308

Merged
merged 3 commits into from Mar 7, 2023

Conversation

AndrewADev
Copy link
Contributor

Update CI config to use the most recent LTS.

For some other possible values, see: https://docs.travis-ci.com/user/languages/javascript-with-nodejs/#specifying-nodejs-versions

Closes #2305

Update CI config to use the most recent LTS.

For some other possible values, see: https://docs.travis-ci.com/user/languages/javascript-with-nodejs/#specifying-nodejs-versions
Request a newer runner version from Travis CI due to a glibc version bump in newer versions of Node.
This would buy even more time to find an alternative to pinning the runner version.
@AndrewADev
Copy link
Contributor Author

RE: initial error on this PR (possibly the same one that caused the Node version revert in the first place) - It seems that the default runner version -- 16.04 of Ubuntu:
image

...doesn't include the glibc versions needed by newer versions of Node. See this comment here

As such, I have set the runner to use Jammy Jellyfish (22.04) for now, which is along the same lines as the suggestions for this error on the Travis CI forums (just slightly newer).

In theory, the named dist can be removed if/when Travis bumps the default OS version to one that uses supported glibc versions. Otherwise, the currently pinned version should be supported several years into the future.

@AndrewADev AndrewADev marked this pull request as ready for review February 28, 2023 20:27
Copy link
Member

@iangilman iangilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Thank you for doing the leg work to track down an appropriate distro! And thank you for including the comment so we can remember why we did it like this.

@iangilman iangilman merged commit 25b4d7a into openseadragon:master Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use current Node LTS (or newer) in CI
2 participants