Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check hash in viewer constructor. #255

Merged
merged 1 commit into from Oct 14, 2013

Conversation

avandecreme
Copy link
Member

Fix #229
Fix #176

@iangilman
Copy link
Member

Awesome, good find!

iangilman added a commit that referenced this pull request Oct 14, 2013
Check hash in viewer constructor.
@iangilman iangilman merged commit 6655523 into openseadragon:master Oct 14, 2013
@iangilman
Copy link
Member

Any thoughts on how to make a test for this case?

iangilman added a commit that referenced this pull request Oct 14, 2013
@avandecreme
Copy link
Member Author

I guess we can check that an error is thrown if neither id and hash is specified.

@iangilman
Copy link
Member

Sounds reasonable. I was also wondering about the higher-level test of "images in collections resolve properly"... seems trickier.

Would you be up for writing a test for this?

@wynnme
Copy link

wynnme commented Nov 13, 2013

@avandecreme , @iangilman
I am using 0.9.131 but need a fix for #180 (multiple image takes a lot of memory). According to the comments, changelog #255 (Check hash in viewer constructor) is related, but I am skeptical that it alone fixes the memory leak. Do either of you (or anyone) know which specific changes would fix issue #180?
Thanks!

@avandecreme
Copy link
Member Author

This commit fixes the zooming problem referenced in #180
Here is what I wrote about the memory:

Not sure about the memory problem but it might be fixed too (maybe the improper filling of the hash table was causing a leak).

@iangilman
Copy link
Member

@wynnme I do not know enough about the memory leak to say for sure. I was taking @shipon-eye's report that it had been fixed:

#180 (comment)

Can you test with it and see if it's fixed for you as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rendering dzc with openseadragon openseadragon tileSources: not all the images are updating tiles on zooming
3 participants