Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct IIIF tile source to use canonical syntax #586

Merged
merged 1 commit into from Feb 5, 2015

Conversation

jpstroop
Copy link
Contributor

@jpstroop jpstroop commented Feb 4, 2015

The IIIF canonical syntax is defined here: http://iiif.io/api/image/2.0/#canonical-uri-syntax. It was added in the 2.0 release of the spec in order to facilitate the creation of static image collections using a common syntax that clients would expect and servers could expose using only a file system.

OpenSeadragon does not presently use full when requesting the whole image (at lower levels) from IIIF 2.0-compliant servers. Instead it uses 0,0,<full_width>,<full_height>. Functionally these are the same, but it breaks static collections and optimized servers.

Specifically, this.tile_width and this.tile_height (here) were not defined for IIIF 2.0 requests, and so the else block was always executed.

/cc @azaroth42

@azaroth42
Copy link
Contributor

+1 :)

@iangilman
Copy link
Member

Thanks!

iangilman added a commit that referenced this pull request Feb 5, 2015
Correct IIIF tile source to use canonical syntax
@iangilman iangilman merged commit dfe465f into openseadragon:master Feb 5, 2015
@jpstroop
Copy link
Contributor Author

jpstroop commented Feb 5, 2015

👍

iangilman added a commit that referenced this pull request Feb 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants