Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add editorconfig #637

Merged
merged 1 commit into from Apr 13, 2015
Merged

Conversation

philipgiuliani
Copy link
Contributor

Editorconfig is a very common configuration method for nearly every IDE and because of that perfect for open source projects.

What you think about removing the openseadragon.sublime-project file?

@iangilman
Copy link
Member

Looks like a great addition. Is there any reason we can't have both? The Sublime project file adds additional things you can't do with the Editorconfig. Of course if I'm the only one who uses those things, I can move the file out of the repository, but if it's useful to others, might as well have both?

@philipgiuliani
Copy link
Contributor Author

No i think there's no problem to use both! Maybe you can test it, because i am not using Sublime (Atom user)? Theoretically the editorconfig should overwrite the settings of sublime config since it gets loaded later.

I just dont wanted to end up with a config for every IDE :)

@iangilman
Copy link
Member

Agreed. Well, we'll leave the Sublime file in for now for historical purposes, but otherwise hopefully the Editorconfig will cover everyone.

iangilman added a commit that referenced this pull request Apr 13, 2015
@iangilman iangilman merged commit d78b806 into openseadragon:master Apr 13, 2015
@philipgiuliani
Copy link
Contributor Author

I hope so, maybe we could add a link to editorconfig under the Contributing section.

iangilman added a commit that referenced this pull request Apr 13, 2015
@iangilman
Copy link
Member

Good point. Care to do that?

@philipgiuliani
Copy link
Contributor Author

Jep added on my TODO 👍

@philipgiuliani philipgiuliani deleted the add-editorconfig branch April 13, 2015 17:18
@iangilman iangilman mentioned this pull request Apr 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants