Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed placeholderFillStyle flicker #727

Merged
merged 4 commits into from Sep 16, 2015
Merged

Fixed placeholderFillStyle flicker #727

merged 4 commits into from Sep 16, 2015

Conversation

TMUND
Copy link
Contributor

@TMUND TMUND commented Sep 15, 2015

In regards to fixing #635 ...

@@ -1151,6 +1152,7 @@ function blendTile( tiledImage, tile, x, y, level, levelOpacity, currentTime ){

if ( opacity == 1 ) {
setCoverage( tiledImage.coverage, level, x, y, true );
this._hasOpaqueTile = true;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be tiledImage instead of this

@iangilman
Copy link
Member

Add context.save(); above https://github.com/openseadragon/openseadragon/blob/master/src/tile.js#L268 and context.restore(); at the bottom of the function.

@iangilman iangilman changed the title Suggested changes for a fix Fixed placeholderFillStyle flicker Sep 16, 2015
@iangilman
Copy link
Member

Beautiful!

iangilman added a commit that referenced this pull request Sep 16, 2015
Fixed placeholderFillStyle flicker
@iangilman iangilman merged commit 0003b1c into openseadragon:master Sep 16, 2015
iangilman added a commit that referenced this pull request Sep 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants