Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RELEASING.md #184

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update RELEASING.md #184

wants to merge 2 commits into from

Conversation

mashah
Copy link

@mashah mashah commented Jan 24, 2024

Proposed an update to create a process with involvement from the leadership committee for moving the release date.

Description

See above.

Issues Resolved

See above.

Proposed an update to create a process for moving the release date.

Signed-off-by: Mehul A. Shah <mashah@gmail.com>
@@ -110,6 +110,16 @@ OpenSearch only does major releases when there are significant breaking changes

For the actual steps to build a release, please see [Releasing OpenSearch](https://github.com/opensearch-project/opensearch-build/blob/main/README.md#releasing-opensearch).

### Release Process for Changing Release Date
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add to TOC please.

How about we make a section called "Release Process" and sub-topics "Major Releases" and "Changing Release Dates"?

@@ -110,6 +110,16 @@ OpenSearch only does major releases when there are significant breaking changes

For the actual steps to build a release, please see [Releasing OpenSearch](https://github.com/opensearch-project/opensearch-build/blob/main/README.md#releasing-opensearch).

### Release Process for Changing Release Date

In the OpenSearch project, we strive for consistent and predictable release schedule as multiple organizations and users depend on the software for their own projects and businesses.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to link to the place that says how (often) OpenSearch releases.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should update https://opensearch.org/releases.html#release-schedule with these details as well.

* There is a publicly documented justification for moving the release date.
* The justification is circulated 2 weeks or more prior to the original release date.
* The organization coordinating the release is in favor of moving the release date.
* A majority of the leadership committee agree by vote to move the release date.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a link that talks about what the leadership committee is anywhere on .github? We should add it if we don't.

This might read clearer: "The leadership committee has voted to move the release date with a simple majority."

Copy link
Member

@bbarani bbarani Jan 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed @dblock . We should document the roles and responsibilities of leadership committee to avoid ambiguity.

However, sometimes a release date needs to move to accommodate engineering delays in critical components that affect the key properties of the software such as
performance, reliability, availability, or security. In order to move a release date, we will ensure:

* There is a publicly documented justification for moving the release date.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say where we document it, aka the release ticket.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Example of a release ticket: opensearch-project/opensearch-build#4115. Should the release ticket itself should go into the public roadmap: https://github.com/orgs/opensearch-project/projects/1?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again this should also go in to https://opensearch.org/releases.html

performance, reliability, availability, or security. In order to move a release date, we will ensure:

* There is a publicly documented justification for moving the release date.
* The justification is circulated 2 weeks or more prior to the original release date.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is posted no later than 2 weeks ...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we elaborate on documented justification? Is it GitHub issue in specific repo, Slack or something else..

@Pallavi-AWS
Copy link
Member

Thanks for initiating this thread @mashah. Agree with LC review, however, primary drivers on date pushout will be a vote from maintainers and the infrastructure/release team that manages the release as they are aware of the technical challenges/last minute issues that might have led to a release delay. We need to still work through voting on github, but need to give enough time for stakeholders to review the proposed change


* There is a publicly documented justification for moving the release date.
* The justification is circulated 2 weeks or more prior to the original release date.
* The organization coordinating the release is in favor of moving the release date.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might be a nitpick: If the maintainers/release owners are in favor, is that enough? Something about the word "organization" here seems a little funny.

@peternied
Copy link
Member

@mashah Thanks for opening this pull request, its been several weeks without activity, how can I help?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants