-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add workflow templates for a common pattern. #23
Conversation
This change adds two workflow templates for repositories under opensearch-project. The purpose is to adhering to a common pattern for using GitHub actions for CI & CD. Signed-off-by: Rabi Panda <pandarab@amazon.com>
Let's add a GH action badge and enable dummy CI on this repo? |
++ Did you enable this in your fork? Can we see some results? |
I ran one on the common-utils fork based on the workflow template https://github.com/adnapibar/common-utils/runs/3234294435?check_suite_focus=true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice.
Maybe the script should be called dco-signoff-check
just to be super explicit? NBD
@dblock Thanks! Can you please merge it. |
Enable GH actions on your fork for the .github repo, and show me that these workflows work? I think you should do #25 as part of this PR to make sure the workflows are actually function. (I am pretty sure this will fail if we enable it now because those scripts called |
Signed-off-by: Rabi Panda <adnapibar@gmail.com>
Added the DCO check workflow for this repo. Here is how it worked in my .github fork https://github.com/adnapibar/.github/runs/3267249808?check_suite_focus=true Yes, this is not a Gradle based Java project so for these kind of projects we can remove those steps and only keep the DCO check. For all Gradle based Java project the template can be used as is e.g. here is the workflow on the |
I am a little worried about the proliferation of things like |
Description
This change adds GitHub Action workflows templates for repositories under the opensearch-project organization. The purpose is to conform to a common pattern for using GitHub Actions for CI & CD.
Issues Resolved
opensearch-project/opensearch-build#116
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.
Signed-off-by: Rabi Panda pandarab@amazon.com