Skip to content

Commit

Permalink
Fix Node.js download link (#4556)
Browse files Browse the repository at this point in the history
https://mirrors.nodejs.org/ is no longer available which prevents the ability from release builds
being made. Restoring back the original link.

Follow-up should be considered about a caching mechanism and param to the CLI to utilize another link or path.

Signed-off-by: Miki <miki@amazon.com>
  • Loading branch information
AMoo-Miki committed Jul 12, 2023
1 parent b94a62f commit d746595
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
- [Saved Objects Management] Fix relationships header overflow ([#4070](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/4070))
- Update main menu to display 'Dashboards' for consistency ([#4453](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/4453))
- [Multiple DataSource] Retain the original sample data API ([#4526](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/4526))
- Fix Node.js download link ([#4556](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/4556))

### 馃殲 Infrastructure

Expand Down
4 changes: 2 additions & 2 deletions src/dev/build/tasks/nodejs/node_download_info.ts
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ export async function getNodeDownloadInfo(config: Config, platform: Platform) {
? `node-v${version}-win-x64.zip`
: `node-v${version}-${arch}.tar.gz`;

const url = `https://mirrors.nodejs.org/dist/v${version}/${downloadName}`;
const url = `https://nodejs.org/dist/v${version}/${downloadName}`;
const downloadPath = config.resolveFromRepo('.node_binaries', version, basename(downloadName));
const extractDir = config.resolveFromRepo('.node_binaries', version, arch);

Expand All @@ -69,7 +69,7 @@ export async function getNodeVersionDownloadInfo(
? `node-v${version}-win-x64.zip`
: `node-v${version}-${architecture}.tar.gz`;

const url = `https://mirrors.nodejs.org/dist/v${version}/${downloadName}`;
const url = `https://nodejs.org/dist/v${version}/${downloadName}`;
const downloadPath = resolve(repoRoot, '.node_binaries', version, basename(downloadName));
const extractDir = resolve(repoRoot, '.node_binaries', version, architecture);

Expand Down

0 comments on commit d746595

Please sign in to comment.