Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tests] enable integration tests ignored due to invalid snapshot url #242

Closed
kavilla opened this issue Apr 1, 2021 · 0 comments · Fixed by #466
Closed

[Tests] enable integration tests ignored due to invalid snapshot url #242

kavilla opened this issue Apr 1, 2021 · 0 comments · Fixed by #466
Assignees
@kavilla
Labels
test:integration
Projects
Dashboards Core

Comments

@kavilla
Copy link
Member

kavilla commented Apr 1, 2021

Description
In the file osd-opensearch/src/artifact.js there is a reference to the snapshot URL that is invalid, however, a valid link is required for the tests in ui_settings/integration_tests/index.test.ts and ui_settings/create_or_upgrade_saved_config/integration_tests/create_or_upgrade.test.ts to run successfully. Since we do not currently have a replacement URL or alternative these tests were ignored for the purpose of successful integration runs of tests that are not blocked due to an external dependency.

Once there is a valid snapshot URL or an alternative is in place, then these tests can be re-enabled. But until than this issue is BLOCKED.

To Reproduce
Steps to reproduce the behavior:

  1. Enable tests that were ignored in ui_settings/integration_tests/index.test.ts and ui_settings/create_or_upgrade_saved_config/integration_tests/create_or_upgrade.test.ts
  2. Run yarn run test:jest_integration
  3. See test failures

Expected behavior
Successful run of integration tests with no test failures

OpenSearch Version
n/a

Dashboards Version
n/a

Plugins

n/a

Screenshots

n/a

Host/Environment (please complete the following information):

  • OS: Ubuntu
  • Browser and version [e.g. 22]: n/a

Additional context

Currently blocked until we get a snapshot URL or alternative.
@kavilla kavilla self-assigned this Apr 1, 2021
@kavilla kavilla added this to To do in Dashboards Core via automation Apr 1, 2021
@kavilla kavilla mentioned this issue Apr 1, 2021
Merged
3 tasks
@kavilla kavilla added >Fork and removed >Fork labels Apr 1, 2021
@kavilla kavilla mentioned this issue May 30, 2021
Closed
kavilla added a commit to kavilla/OpenSearch-Dashboards-1 that referenced this issue Jun 8, 2021
@kavilla
[Tests] updated artifact script
ef74e83 
Updating artifact to enable issue opensearch-project#242 and #19.
Unit tests are failing, need to update them.

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
kavilla added a commit to kavilla/OpenSearch-Dashboards-1 that referenced this issue Jun 9, 2021
@kavilla
[Tests] updated artifact script
447a94c 
Updating artifact to enable running integration tests and functional
tests to pull an artifact from the current hosted distributions.

At the time of this commit, there is not manifest hosted but there are
static links which can have an unknown amount of RC versions if the
GA snapshot does not exist for that version. But the assumption
is that it will not be too high.

Deprecating the previous implementation but we can remove that in a
future iteration. Wanted to leave that available incase others use
that for custom manifests.

Enable tests that depended on snapshots as well.

Issues resolved:
opensearch-project#242
opensearch-project#19

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
kavilla added a commit to kavilla/OpenSearch-Dashboards-1 that referenced this issue Jun 9, 2021
@kavilla
[Tests] updated artifact script
c53daf9 
Updating artifact to enable running integration tests and functional
tests to pull an artifact from the current hosted distributions.

At the time of this commit, there is not manifest hosted but there are
static links which can have an unknown amount of RC versions if the
GA snapshot does not exist for that version. But the assumption
is that it will not be too high.

Deprecating the previous implementation but we can remove that in a
future iteration. Wanted to leave that available incase others use
that for custom manifests.

Enable tests that depended on snapshots as well.

Issues resolved:
opensearch-project#242
opensearch-project#19

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
@kavilla kavilla mentioned this issue Jun 9, 2021
Merged
5 tasks
@kavilla kavilla linked a pull request Jun 9, 2021 that will close this issue
[Tests] updated artifact script #466
Merged
5 tasks
kavilla added a commit to kavilla/OpenSearch-Dashboards-1 that referenced this issue Jun 10, 2021
@kavilla
[Tests] updated artifact script
8fc5fe7 
Updating artifact to enable running integration tests and functional
tests to pull an artifact from the current hosted distributions.

At the time of this commit, there is not manifest hosted but there are
static links which can have an unknown amount of RC versions if the
GA snapshot does not exist for that version. But the assumption
is that it will not be too high.

Deprecating the previous implementation but we can remove that in a
future iteration. Wanted to leave that available incase others use
that for custom manifests.

Enable tests that depended on snapshots as well.

Issues resolved:
opensearch-project#242
opensearch-project#19

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
kavilla added a commit to kavilla/OpenSearch-Dashboards-1 that referenced this issue Jun 10, 2021
@kavilla
[Tests] updated artifact script
1e7eaec 
Updating artifact to enable running integration tests and functional
tests to pull an artifact from the current hosted distributions.

At the time of this commit, there is not manifest hosted but there are
static links which can have an unknown amount of RC versions if the
GA snapshot does not exist for that version. But the assumption
is that it will not be too high.

Deprecating the previous implementation but we can remove that in a
future iteration. Wanted to leave that available incase others use
that for custom manifests.

Enable tests that depended on snapshots as well.

Issues resolved:
opensearch-project#242
opensearch-project#19

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
kavilla added a commit to kavilla/OpenSearch-Dashboards-1 that referenced this issue Jun 11, 2021
@kavilla
[Tests] updated artifact script
494115e 
Updating artifact to enable running integration tests and functional
tests to pull an artifact from the current hosted distributions.

At the time of this commit, there is not manifest hosted but there are
static links which can have an unknown amount of RC versions if the
GA snapshot does not exist for that version. But the assumption
is that it will not be too high.

Deprecating the previous implementation but we can remove that in a
future iteration. Wanted to leave that available incase others use
that for custom manifests.

Enable tests that depended on snapshots as well.

Issues resolved:
opensearch-project#242
opensearch-project#19

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
kavilla added a commit to kavilla/OpenSearch-Dashboards-1 that referenced this issue Jun 11, 2021
@kavilla
[Tests] updated artifact script
bf0097a 
Updating artifact to enable running integration tests and functional
tests to pull an artifact from the current hosted distributions.

At the time of this commit, there is not manifest hosted but there are
static links which can have an unknown amount of RC versions if the
GA snapshot does not exist for that version. But the assumption
is that it will not be too high.

Deprecating the previous implementation but we can remove that in a
future iteration. Wanted to leave that available incase others use
that for custom manifests.

Enable tests that depended on snapshots as well.

Issues resolved:
opensearch-project#242
opensearch-project#19

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Dashboards Core automation moved this from To do to Done Jun 11, 2021
kavilla added a commit that referenced this issue Jun 11, 2021
@kavilla
[Tests] updated artifact script (#466)
daa686f 
Updating artifact to enable running integration tests and functional
tests to pull an artifact from the current hosted distributions.

At the time of this commit, there is not manifest hosted but there are
static links which can have an unknown amount of RC versions if the
GA snapshot does not exist for that version. But the assumption
is that it will not be too high.

Deprecating the previous implementation but we can remove that in a
future iteration. Wanted to leave that available incase others use
that for custom manifests.

Enable tests that depended on snapshots as well.

Issues resolved:
#242
#19

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
kavilla added a commit that referenced this issue Jun 21, 2021
@kavilla
[Tests] updated artifact script (#466)
f0c1bf3 
Updating artifact to enable running integration tests and functional
tests to pull an artifact from the current hosted distributions.

At the time of this commit, there is not manifest hosted but there are
static links which can have an unknown amount of RC versions if the
GA snapshot does not exist for that version. But the assumption
is that it will not be too high.

Deprecating the previous implementation but we can remove that in a
future iteration. Wanted to leave that available incase others use
that for custom manifests.

Enable tests that depended on snapshots as well.

Issues resolved:
#242
#19

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
kavilla added a commit that referenced this issue Jun 21, 2021
@kavilla
[Tests] updated artifact script (#466)
1bbc5db 
Updating artifact to enable running integration tests and functional
tests to pull an artifact from the current hosted distributions.

At the time of this commit, there is not manifest hosted but there are
static links which can have an unknown amount of RC versions if the
GA snapshot does not exist for that version. But the assumption
is that it will not be too high.

Deprecating the previous implementation but we can remove that in a
future iteration. Wanted to leave that available incase others use
that for custom manifests.

Enable tests that depended on snapshots as well.

Issues resolved:
#242
#19

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
raintygao pushed a commit to raintygao/OpenSearch-Dashboards that referenced this issue Oct 26, 2023
@wanglam
Feat disable duplicate user or group permission (opensearch-project#242)
1d679f8 
* feat: throw error when create or update with invalid permission modes

Signed-off-by: Lin Wang <wonglam@amazon.com>

* feat: show error when duplicate permissions for spefic user or group

Signed-off-by: Lin Wang <wonglam@amazon.com>

* feat: mark permissions optional

Signed-off-by: Lin Wang <wonglam@amazon.com>

* feat: change to WorkpsacePermissionItems for workspace client interfaces

Signed-off-by: Lin Wang <wonglam@amazon.com>

---------

Signed-off-by: Lin Wang <wonglam@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kavilla kavilla

Labels
test:integration
Projects
Dashboards Core
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Tests] updated artifact script kavilla/OpenSearch-Dashboards-1
1 participant
@kavilla