Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Errors building docker container #285

Closed
jgough opened this issue Apr 13, 2021 · 3 comments · Fixed by #289
Closed

[BUG] Errors building docker container #285

jgough opened this issue Apr 13, 2021 · 3 comments · Fixed by #289
Labels
bug Something isn't working
Milestone

Comments

@jgough
Copy link
Contributor

jgough commented Apr 13, 2021

I am trying to build a docker container with OpenSearch-Dashboards, but this fails with the following error:

   │      Step 23/31 : COPY --chown=1000:0 config/kibana.yml /usr/share/kibana/config/kibana.yml
   │          at makeError (/mnt/build/OpenSearch-Dashboards/node_modules/execa/lib/error.js:59:11)
   │          at handlePromise (/mnt/build/OpenSearch-Dashboards/node_modules/execa/index.js:114:26)
   │          at process._tickCallback (internal/process/next_tick.js:68:7)

error Command failed with exit code 1.

The Dockerfile that I think is generated by src/dev/build/tasks/os_packages/docker_generator/templates/Dockerfile seems to reference kibana many times so guessing needs to be updated?

To Reproduce
Steps to reproduce the behavior:
Run the following commands

yarn osd bootstrap --force-install --allow-root
yarn build --docker

Expected behavior
A docker container is built

@jgough jgough added the bug Something isn't working label Apr 13, 2021
@jgough
Copy link
Contributor Author

jgough commented Apr 13, 2021

I replaced kibana with opensearch-dashboards (and opensearch_dashboards for the config file) throughout this file and it successfully built. Need to think about image names though as his creates then creates the image docker.opensearch.co/opensearch-dashboards/opensearch-dashboards, which is the wrong host.

Running a container built in this manner results in the following:

$ docker run -it --rm docker.opensearch.co/opensearch-dashboards/opensearch-dashboards:7.10.2-SNAPSHOT
  log   [23:17:44.331] [info][plugins-service] Plugin "visTypeXy" is disabled.
  log   [23:17:44.365] [fatal][root] { Error: Unknown configuration key(s): "monitoring.ui.container.opensearch.enabled". Check for spelling errors and ensure that expected plugins are installed.
    at ensureValidConfiguration (/usr/share/opensearch-dashboards/src/core/server/legacy/config/ensure_valid_configuration.js:55:11) code: 'InvalidConfig', processExitCode: 64, cause: undefined }

 FATAL  Error: Unknown configuration key(s): "monitoring.ui.container.opensearch.enabled". Check for spelling errors and ensure that expected plugins are installed.

Guessing this is now coming from src/dev/build/tasks/os_packages/docker_generator/templates/opensearch_dashboards_yml.template.ts

@jgough
Copy link
Contributor Author

jgough commented Apr 13, 2021

Removing the line
${!imageFlavor ? 'monitoring.ui.container.opensearch.enabled: true' : ''}
from src/dev/build/tasks/os_packages/docker_generator/templates/opensearch_dashboards_yml.template.ts

Seems to fix this and makes the docker container run. Would you like me to submit a pull request with these changes?

@mihirsoni
Copy link
Contributor

mihirsoni commented Apr 14, 2021

@jgough Thank you for reporting this issue. Let us know if you would like to contribute and create PR for the same.

@mihirsoni mihirsoni added this to the 1.x release milestone Apr 14, 2021
@mihirsoni mihirsoni added this to To do in Dashboards Core via automation Apr 14, 2021
@kavilla kavilla linked a pull request Apr 14, 2021 that will close this issue
5 tasks
@kavilla kavilla moved this from To do to Needs Review in Dashboards Core Apr 14, 2021
Dashboards Core automation moved this from Needs Review to Done Apr 15, 2021
wanglam pushed a commit to wanglam/OpenSearch-Dashboards that referenced this issue Mar 12, 2024
* feat: add workspace list

Signed-off-by: tygao <tygao@amazon.com>

* update index.ts

Signed-off-by: tygao <tygao@amazon.com>

* test: update workspace plugin test

Signed-off-by: tygao <tygao@amazon.com>

* remove extra file and add test for modal

Signed-off-by: tygao <tygao@amazon.com>

* test: add tests for workspace util

Signed-off-by: tygao <tygao@amazon.com>

* test: update test for delete_workspace_modal

Signed-off-by: tygao <tygao@amazon.com>

* test: update test for delete_workspace_modal

Signed-off-by: tygao <tygao@amazon.com>

* test: update test for workspace list

Signed-off-by: tygao <tygao@amazon.com>

* rename and update test

Signed-off-by: tygao <tygao@amazon.com>

* add tests for workspace list

Signed-off-by: tygao <tygao@amazon.com>

---------

Signed-off-by: tygao <tygao@amazon.com>
SuZhou-Joe pushed a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this issue Mar 18, 2024
* feat: add workspace list

Signed-off-by: tygao <tygao@amazon.com>

* update index.ts

Signed-off-by: tygao <tygao@amazon.com>

* test: update workspace plugin test

Signed-off-by: tygao <tygao@amazon.com>

* remove extra file and add test for modal

Signed-off-by: tygao <tygao@amazon.com>

* test: add tests for workspace util

Signed-off-by: tygao <tygao@amazon.com>

* test: update test for delete_workspace_modal

Signed-off-by: tygao <tygao@amazon.com>

* test: update test for delete_workspace_modal

Signed-off-by: tygao <tygao@amazon.com>

* test: update test for workspace list

Signed-off-by: tygao <tygao@amazon.com>

* rename and update test

Signed-off-by: tygao <tygao@amazon.com>

* add tests for workspace list

Signed-off-by: tygao <tygao@amazon.com>

---------

Signed-off-by: tygao <tygao@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

Successfully merging a pull request may close this issue.

2 participants