Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] [Data Explorer] Data Explorer does not respect global time filter anymore #5056

Closed
abbyhu2000 opened this issue Sep 18, 2023 · 3 comments · Fixed by #5168
Closed

[BUG] [Data Explorer] Data Explorer does not respect global time filter anymore #5056

abbyhu2000 opened this issue Sep 18, 2023 · 3 comments · Fixed by #5168
Assignees
@ashwin-pc
Labels
bug Something isn't working data explorer Issues related to the Data Explorer project de-angular de-angularize work v2.11.0

Comments

@abbyhu2000
Copy link
Member

abbyhu2000 commented Sep 18, 2023 •
edited

Describe the bug
When we save a new saved search and reload that saved search, the global time filter is lost and always reset back to default.

When we click reset button on a loaded saved search, the time filter does not persist and always goes back to the default as well.

Expected behavior
Time filter should be persisted globally.

Current behavior:

Screen.Recording.2023-09-18.at.1.27.18.PM.mov

Expected behavior:

Screen.Recording.2023-09-18.at.1.27.58.PM.mov
@abbyhu2000 abbyhu2000 added bug Something isn't working untriaged data explorer Issues related to the Data Explorer project labels Sep 18, 2023
@abbyhu2000 abbyhu2000 changed the title [BUG] [Data Explorer] Save search object does not save time filter anymore [BUG] [Data Explorer] Data Explorer does not respect global time filter anymore Sep 18, 2023
@ashwin-pc ashwin-pc added de-angular de-angularize work v2.11.0 and removed untriaged labels Sep 18, 2023
@joshuali925
Copy link
Member

this also affects reporting since it assumes that the time filter value is in the URL opensearch-project/dashboards-reporting#190

@abbyhu2000 abbyhu2000 mentioned this issue Sep 19, 2023
Merged
1 task
@ashwin-pc ashwin-pc mentioned this issue Sep 26, 2023
Closed
8 tasks
@ashwin-pc ashwin-pc self-assigned this Sep 29, 2023
@ashwin-pc ashwin-pc mentioned this issue Oct 2, 2023
Merged
8 tasks
@abbyhu2000 abbyhu2000 reopened this Oct 4, 2023
@abbyhu2000
Copy link
Member Author

@ashwin-pc I don't think this is resolved. The bug still persists: when i load the saved search, time filter still resets back to the default.

@abbyhu2000
Copy link
Member Author

Verified it is working, close the issue.

kavilla pushed a commit to opensearch-project/opensearch-dashboards-functional-test that referenced this issue Oct 13, 2023
@abbyhu2000
Cypress tests for data explorer (#862)
7cf0a03 
Migrate the old selenium tests for discover to cypress tests for data explorer.
PR [for #5003](opensearch-project/OpenSearch-Dashboards#5072) needs to be merged first.

Below are a list of bugs found when writing the tests, the tests for the below feature are skipped and commented with the issue link:

- opensearch-project/OpenSearch-Dashboards#5071
- opensearch-project/OpenSearch-Dashboards#5068
- opensearch-project/OpenSearch-Dashboards#5058
- opensearch-project/OpenSearch-Dashboards#5057
- opensearch-project/OpenSearch-Dashboards#5056

### Issues Resolved
resolves opensearch-project/OpenSearch-Dashboards#4781

---------

Signed-off-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
opensearch-trigger-bot bot pushed a commit to opensearch-project/opensearch-dashboards-functional-test that referenced this issue Oct 13, 2023
@abbyhu2000 @github-actions
Cypress tests for data explorer (#862)
58fdd15 
Migrate the old selenium tests for discover to cypress tests for data explorer.
PR [for #5003](opensearch-project/OpenSearch-Dashboards#5072) needs to be merged first.

Below are a list of bugs found when writing the tests, the tests for the below feature are skipped and commented with the issue link:

- opensearch-project/OpenSearch-Dashboards#5071
- opensearch-project/OpenSearch-Dashboards#5068
- opensearch-project/OpenSearch-Dashboards#5058
- opensearch-project/OpenSearch-Dashboards#5057
- opensearch-project/OpenSearch-Dashboards#5056

### Issues Resolved
resolves opensearch-project/OpenSearch-Dashboards#4781

---------

Signed-off-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
(cherry picked from commit 7cf0a03)
opensearch-trigger-bot bot pushed a commit to opensearch-project/opensearch-dashboards-functional-test that referenced this issue Oct 13, 2023
@abbyhu2000 @github-actions
Cypress tests for data explorer (#862)
210a28a 
Migrate the old selenium tests for discover to cypress tests for data explorer.
PR [for #5003](opensearch-project/OpenSearch-Dashboards#5072) needs to be merged first.

Below are a list of bugs found when writing the tests, the tests for the below feature are skipped and commented with the issue link:

- opensearch-project/OpenSearch-Dashboards#5071
- opensearch-project/OpenSearch-Dashboards#5068
- opensearch-project/OpenSearch-Dashboards#5058
- opensearch-project/OpenSearch-Dashboards#5057
- opensearch-project/OpenSearch-Dashboards#5056

### Issues Resolved
resolves opensearch-project/OpenSearch-Dashboards#4781

---------

Signed-off-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
(cherry picked from commit 7cf0a03)
kavilla pushed a commit to opensearch-project/opensearch-dashboards-functional-test that referenced this issue Oct 13, 2023
@opensearch-trigger-bot @abbyhu2000
Cypress tests for data explorer (#862) (#928)
6492d1f 
Migrate the old selenium tests for discover to cypress tests for data explorer.
PR [for #5003](opensearch-project/OpenSearch-Dashboards#5072) needs to be merged first.

Below are a list of bugs found when writing the tests, the tests for the below feature are skipped and commented with the issue link:

- opensearch-project/OpenSearch-Dashboards#5071
- opensearch-project/OpenSearch-Dashboards#5068
- opensearch-project/OpenSearch-Dashboards#5058
- opensearch-project/OpenSearch-Dashboards#5057
- opensearch-project/OpenSearch-Dashboards#5056

### Issues Resolved
resolves opensearch-project/OpenSearch-Dashboards#4781

---------

Signed-off-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
(cherry picked from commit 7cf0a03)

Co-authored-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
kavilla pushed a commit to opensearch-project/opensearch-dashboards-functional-test that referenced this issue Oct 13, 2023
@opensearch-trigger-bot @abbyhu2000
Cypress tests for data explorer (#862) (#929)
4d39829 
Migrate the old selenium tests for discover to cypress tests for data explorer.
PR [for #5003](opensearch-project/OpenSearch-Dashboards#5072) needs to be merged first.

Below are a list of bugs found when writing the tests, the tests for the below feature are skipped and commented with the issue link:

- opensearch-project/OpenSearch-Dashboards#5071
- opensearch-project/OpenSearch-Dashboards#5068
- opensearch-project/OpenSearch-Dashboards#5058
- opensearch-project/OpenSearch-Dashboards#5057
- opensearch-project/OpenSearch-Dashboards#5056

### Issues Resolved
resolves opensearch-project/OpenSearch-Dashboards#4781

---------

Signed-off-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
(cherry picked from commit 7cf0a03)

Co-authored-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ashwin-pc ashwin-pc

Labels
bug Something isn't working data explorer Issues related to the Data Explorer project de-angular de-angularize work v2.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Discover] A bunch of navigation fixes ashwin-pc/OpenSearch-Dashboards
4 participants
@AMoo-Miki @ashwin-pc @joshuali925 @abbyhu2000