Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Features] Configurable rows per page in the discover view #5569

Closed
albgus opened this issue Dec 4, 2023 · 3 comments · Fixed by #5610
Closed

[Features] Configurable rows per page in the discover view #5569

albgus opened this issue Dec 4, 2023 · 3 comments · Fixed by #5610
Assignees
Labels
data explorer Issues related to the Data Explorer project discover for discover reinvent enhancement New feature or request

Comments

@albgus
Copy link

albgus commented Dec 4, 2023

Is your feature request related to a problem? Please describe.

The new discover view splits search results into pages instead of automatically loading new pages as you scroll downwards. Looking through large search results were much easier when not having to navigate through pages and having 100 results per page isn't very much when dealing with large log files. It also restricts quick searching back with Ctrl+F in the browser if things are no longer on the same page.

Describe the solution you'd like

I'd like to be able to be able to either switch back to the old behaviour, or at least be able to configure the number of results per page as an advanced setting to increase the results shown at the same time.

Additional context

Inspecting the Network page of the browser DevTools it seems that all results are fetched in one request, so I'm not even sure what purpose the pages serve if everything is returned at the same time anyway?

@albgus albgus added the enhancement New feature or request label Dec 4, 2023
@joshuarrrr joshuarrrr added discover for discover reinvent and removed untriaged labels Dec 5, 2023
@joshuarrrr
Copy link
Member

I think making the page size configurable is a good solution. @ananzh and @ashwin-pc what do you think?

@ashwin-pc ashwin-pc added the data explorer Issues related to the Data Explorer project label Dec 13, 2023
@kishor82
Copy link
Contributor

kishor82 commented Dec 14, 2023

similar to #5601

@ashwin-pc
Copy link
Member

@albgus Does the solution proposed in #5610 address your problem?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data explorer Issues related to the Data Explorer project discover for discover reinvent enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants