[Discover] Data Grid Pagination Options #5610

kishor82 · 2023-12-13T22:54:31Z

Description

Implemented pagination options based on the Discover UI setting configuration value. #5601 , #5569

Screenshot

Number of rows is set to 1000

Pagination options are updated based on settings

closes #5601
closes #5569

Check List

All tests pass
- yarn test:jest
- yarn test:jest_integration
New functionality includes testing.
New functionality has been documented.
Update CHANGELOG.md
Commits are signed per the DCO using --signoff

codecov · 2023-12-13T23:09:42Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a4ae399) 66.98% compared to head (25e54fe) 67.03%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5610      +/-   ##
==========================================
+ Coverage   66.98%   67.03%   +0.04%     
==========================================
  Files        3294     3295       +1     
  Lines       63318    63329      +11     
  Branches    10083    10084       +1     
==========================================
+ Hits        42416    42451      +35     
+ Misses      18448    18429      -19     
+ Partials     2454     2449       -5

Flag	Coverage Δ
Linux_1	`35.23% <ø> (ø)`
Linux_2	`55.18% <ø> (ø)`
Linux_3	`43.90% <100.00%> (+0.03%)`	⬆️
Linux_4	`35.33% <ø> (ø)`
Windows_1	`35.26% <ø> (ø)`
Windows_2	`55.15% <ø> (?)`
Windows_3	`43.91% <100.00%> (?)`
Windows_4	`35.33% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

kishor82 · 2023-12-14T05:59:30Z

CHANGELOG.md

@@ -945,4 +946,4 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)

 ### 🔩 Tests

- Update caniuse to fix failed integration tests ([#2322](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2322))
+- Update caniuse to fix failed integration tests ([#2322](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2322))


Don't know what changed here!

…lue. Signed-off-by: Kishor Rathva <kishorrathva8298@gmail.com>

Signed-off-by: Kishor Rathva <kishorrathva8298@gmail.com>

ananzh

nice! thank you

Signed-off-by: Kishor Rathva <kishorrathva8298@gmail.com>

kishor82 · 2023-12-19T09:10:41Z

Working on functional testing; those are failing due to UI setting value for sampleSize.

Signed-off-by: kishor82 <kishorrathva8298@gmail.com>

ananzh · 2023-12-21T21:46:29Z

@kishor82 thank you. Feel free to reach out if you need any help for functional tst.

kishor82 · 2023-12-22T04:45:34Z

@kishor82 thank you. Feel free to reach out if you need any help for functional tst.

@ananzh I resolved the functional test issue, and initially, all tests were passing. However, it is currently failing again after the merge. will reach out if needed.

* Added helper function to generate page options based on UI setting value. Signed-off-by: Kishor Rathva <kishorrathva8298@gmail.com> * Added dynamic pagination based on config value for data grid table Signed-off-by: Kishor Rathva <kishorrathva8298@gmail.com> * Update changelog Signed-off-by: Kishor Rathva <kishorrathva8298@gmail.com> * Removed service object from the props. Signed-off-by: kishor82 <kishorrathva8298@gmail.com> * Added suggested changes and updated tests. Signed-off-by: kishor82 <kishorrathva8298@gmail.com> * fix functional test issue due to ui setting Signed-off-by: kishor82 <kishorrathva8298@gmail.com> --------- Signed-off-by: Kishor Rathva <kishorrathva8298@gmail.com> Signed-off-by: kishor82 <kishorrathva8298@gmail.com> (cherry picked from commit e83b7ee) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md

* Added helper function to generate page options based on UI setting value. Signed-off-by: Kishor Rathva <kishorrathva8298@gmail.com> * Added dynamic pagination based on config value for data grid table Signed-off-by: Kishor Rathva <kishorrathva8298@gmail.com> * Update changelog Signed-off-by: Kishor Rathva <kishorrathva8298@gmail.com> * Removed service object from the props. Signed-off-by: kishor82 <kishorrathva8298@gmail.com> * Added suggested changes and updated tests. Signed-off-by: kishor82 <kishorrathva8298@gmail.com> * fix functional test issue due to ui setting Signed-off-by: kishor82 <kishorrathva8298@gmail.com> --------- Signed-off-by: Kishor Rathva <kishorrathva8298@gmail.com> Signed-off-by: kishor82 <kishorrathva8298@gmail.com> (cherry picked from commit e83b7ee) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Added helper function to generate page options based on UI setting value. Signed-off-by: Kishor Rathva <kishorrathva8298@gmail.com> * Added dynamic pagination based on config value for data grid table Signed-off-by: Kishor Rathva <kishorrathva8298@gmail.com> * Update changelog Signed-off-by: Kishor Rathva <kishorrathva8298@gmail.com> * Removed service object from the props. Signed-off-by: kishor82 <kishorrathva8298@gmail.com> * Added suggested changes and updated tests. Signed-off-by: kishor82 <kishorrathva8298@gmail.com> * fix functional test issue due to ui setting Signed-off-by: kishor82 <kishorrathva8298@gmail.com> --------- Signed-off-by: Kishor Rathva <kishorrathva8298@gmail.com> Signed-off-by: kishor82 <kishorrathva8298@gmail.com> Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

kishor82 requested review from ananzh, kavilla, AMoo-Miki, ashwin-pc, joshuarrrr, abbyhu2000, zengyan-amazon, kristenTian, zhongnansu, manasvinibs, ZilongX, Flyingliuhub, BSFishy, curq, bandinib-amzn and SuZhou-Joe as code owners December 13, 2023 22:54

github-actions bot added the first-time-contributor label Dec 13, 2023

kishor82 force-pushed the feature/discover-pagination branch from faf0f17 to 9848607 Compare December 13, 2023 23:23

kishor82 changed the title ~~Discover: Data Grid Pagination Options~~ [Discover]: Data Grid Pagination Options Dec 13, 2023

kishor82 changed the title ~~[Discover]: Data Grid Pagination Options~~ [Discover] Data Grid Pagination Options Dec 13, 2023

kishor82 force-pushed the feature/discover-pagination branch from 9848607 to 0efa3c2 Compare December 14, 2023 05:53

kishor82 commented Dec 14, 2023

View reviewed changes

kishor82 force-pushed the feature/discover-pagination branch from 0efa3c2 to 0a24372 Compare December 14, 2023 19:57

kishor82 added 3 commits December 15, 2023 11:15

Added helper function to generate page options based on UI setting va…

94b95f7

…lue. Signed-off-by: Kishor Rathva <kishorrathva8298@gmail.com>

Added dynamic pagination based on config value for data grid table

484e681

Signed-off-by: Kishor Rathva <kishorrathva8298@gmail.com>

Update changelog

aed8b0d

Signed-off-by: Kishor Rathva <kishorrathva8298@gmail.com>

kishor82 force-pushed the feature/discover-pagination branch from 0a24372 to aed8b0d Compare December 15, 2023 05:45

ananzh previously approved these changes Dec 15, 2023

View reviewed changes

Merge branch 'main' into feature/discover-pagination

dac7ad7

Signed-off-by: Kishor Rathva <kishorrathva8298@gmail.com>

kishor82 force-pushed the feature/discover-pagination branch from d208248 to ed33807 Compare December 19, 2023 08:07

ruanyl approved these changes Dec 19, 2023

View reviewed changes

kishor82 requested a review from ruanyl December 19, 2023 08:15

ruanyl approved these changes Dec 19, 2023

View reviewed changes

fix functional test issue due to ui setting

899516d

Signed-off-by: kishor82 <kishorrathva8298@gmail.com>

kishor82 requested review from ruanyl and ananzh December 19, 2023 13:24

Merge branch 'main' into feature/discover-pagination

37ec704

ashwin-pc mentioned this pull request Dec 20, 2023

[Features] Configurable rows per page in the discover view #5569

Closed

Merge branch 'main' into feature/discover-pagination

348d67c

Merge branch 'main' into feature/discover-pagination

bce296c

kishor82 added 3 commits January 4, 2024 17:43

Merge branch 'main' into feature/discover-pagination

fbf7399

Merge branch 'main' into feature/discover-pagination

24937e6

Merge branch 'main' into feature/discover-pagination

25e54fe

ashwin-pc approved these changes Jan 17, 2024

View reviewed changes

ashwin-pc added discover for discover reinvent v2.12.0 labels Jan 17, 2024

abbyhu2000 approved these changes Jan 17, 2024

View reviewed changes

ashwin-pc added the backport 2.x label Jan 17, 2024

ashwin-pc merged commit e83b7ee into opensearch-project:main Jan 17, 2024
78 checks passed

opensearch-trigger-bot bot mentioned this pull request Jan 17, 2024

[Backport 2.x] [Discover] Data Grid Pagination Options #5701

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Discover] Data Grid Pagination Options #5610

[Discover] Data Grid Pagination Options #5610

kishor82 commented Dec 13, 2023 •

edited by ashwin-pc

codecov bot commented Dec 13, 2023 •

edited

kishor82 Dec 14, 2023

ananzh left a comment

kishor82 commented Dec 19, 2023 •

edited

ananzh commented Dec 21, 2023

kishor82 commented Dec 22, 2023

[Discover] Data Grid Pagination Options #5610

[Discover] Data Grid Pagination Options #5610

Conversation

kishor82 commented Dec 13, 2023 • edited by ashwin-pc

Description

Screenshot

Check List

codecov bot commented Dec 13, 2023 • edited

Codecov Report

kishor82 Dec 14, 2023

Choose a reason for hiding this comment

ananzh left a comment

Choose a reason for hiding this comment

kishor82 commented Dec 19, 2023 • edited

ananzh commented Dec 21, 2023

kishor82 commented Dec 22, 2023

kishor82 commented Dec 13, 2023 •

edited by ashwin-pc

codecov bot commented Dec 13, 2023 •

edited

kishor82 commented Dec 19, 2023 •

edited