Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rename] KQL to DQL (#37) #187

Merged
merged 1 commit into from
Mar 18, 2021
Merged

[Rename] KQL to DQL (#37) #187

merged 1 commit into from
Mar 18, 2021

Conversation

boktorbb
Copy link
Contributor

Signed-off-by: Bishoy Boktor boktorbb@amazon.com

Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
@odfe-release-bot
Copy link

✅   DCO Check Passed

@kavilla
Copy link
Member

kavilla commented Mar 18, 2021

looks nice!

Screen Shot 2021-03-18 at 1 56 49 PM

Copy link
Member

@kavilla kavilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is passing the linter, builds and shows nicely. LGTM! Thanks!

Copy link
Contributor

@mihirsoni mihirsoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!

is Kquery === KQL ?

@boktorbb boktorbb merged commit 58fe31b into opensearch-project:dashboards Mar 18, 2021
kavilla referenced this pull request in kavilla/OpenSearch-Dashboards Mar 19, 2021
Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
kavilla pushed a commit that referenced this pull request Mar 20, 2021
Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
mihirsoni pushed a commit that referenced this pull request Mar 20, 2021
Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants