Updates functional test readme #2492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashwin-pc
force-pushed
the
readme
branch
2 times, most recently
from
3fc0d33
to
df0125e
Compare
abbyhu2000
reviewed
Oct 4, 2022
TESTING.md
Outdated
| @@ -43,6 +43,9 @@ To run specific integration tests, pass the path to the test: | |||
| `yarn test:jest_integration [test path]` | |||
|
|
|||
| ### Functional tests | |||
|
|
|||
| Functional testing in OpenSearch Dashboards is migrating to the [opensearch-dashboards-functional-test](https://github.com/opensearch-project/opensearch-dashboards-functional-test) repository. All new functional tests should be written there. When modifying a file that affects an exisitng functional test, the old test should be migrated to the new repository. The rest of this section outlines how to run the existing functional tests in the repository. | |||
There was a problem hiding this comment.
the old test should be migrated to the new repository.
It would be nice to also have some pointers on how to do this...
There was a problem hiding this comment.
@joshuarrrr We dont have a process to defined for this yet since we havent done a migration. The summary view PR can be a good example where we set precedent and come up with good examples. We can update this text once we do. I wanted to add this message here now because this is where i looked when I was writing tests and didnt see any mention of the FTR repo and its use.
@abbyhu2000 thanks, will make the change
Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
joshuarrrr
approved these changes
Oct 10, 2022
kavilla
approved these changes
Oct 10, 2022
sipopo
pushed a commit
to sipopo/OpenSearch-Dashboards
that referenced
this pull request
Dec 16, 2022
Updates the Readme to call out the change in functional testing for OpenSearch Dashboards Issue resolved: opensearch-project#2462 Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> Signed-off-by: Sergey V. Osipov <sipopo@yandex.ru>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ashwin P Chandran ashwinpc@amazon.com
Description
Updates the Readme to call out the change in functional testing for OpenSearch Dashboards
Issues Resolved
Check List
yarn test:jestyarn test:jest_integrationyarn test:ftr