Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[i18n] Register ru, ru-RU locale #2817

Merged
merged 6 commits into from Nov 22, 2022
Merged

[i18n] Register ru, ru-RU locale #2817

merged 6 commits into from Nov 22, 2022

Conversation

dmitry-by-step-logic
Copy link
Contributor

@dmitry-by-step-logic dmitry-by-step-logic commented Nov 7, 2022 •
edited

Signed-off-by: Dmitry Dudin d_dudin@step.ru

Description

Added ru, ru-RU locales.

Issues Resolved

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@dmitry-by-step-logic
register ru locale
c34e7b2 
Signed-off-by: Dmitry Dudin <d_dudin@step.ru>
@dmitry-by-step-logic dmitry-by-step-logic requested a review from a team as a code owner November 7, 2022 18:37
@dmitry-by-step-logic dmitry-by-step-logic changed the title [i18n] register ru, ru-RU locale [i18n] Register ru, ru-RU locale Nov 10, 2022
@dmitry-by-step-logic dmitry-by-step-logic changed the title [i18n] Register ru, ru-RU locale [i18n] Register ru, ru-RU locale Nov 10, 2022
@ashwin-pc
Copy link
Member

ashwin-pc commented Nov 11, 2022 •
edited

@dmitry-by-step-logic Thanks for the contribution!

@ananzh @seanneumann @ahopp Who is the best person to review this PR and validate the locale information?

@ananzh
Copy link
Member

ananzh commented Nov 11, 2022

@dmitry-by-step-logic Thanks for the contribution!

@ananzh @seanneumann @ahopp Who is the best person to review this PR and validate the locale information?

I could review it. I think this is great. Thank you.

ananzh
ananzh previously approved these changes Nov 11, 2022
View reviewed changes
@ananzh ananzh added i18n Internationalization related Issues and PRs v2.5.0 'Issues and PRs related to version v2.5.0' labels Nov 11, 2022
@dmitry-by-step-logic
Copy link
Contributor Author

@ananzh Thank you for your review. What's next? Two Reviewers are required.

joshuarrrr
joshuarrrr previously approved these changes Nov 18, 2022
View reviewed changes
@kristenTian kristenTian dismissed stale reviews from joshuarrrr and ananzh via 91f3786 November 19, 2022 00:58
@codecov-commenter
Copy link

Codecov Report

Merging #2817 (91f3786) into main (ab98411) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2817      +/-   ##
==========================================
- Coverage   66.68%   66.67%   -0.01%     
==========================================
  Files        3219     3219              
  Lines       61448    61450       +2     
  Branches     9417     9417              
==========================================
- Hits        40975    40971       -4     
- Misses      18229    18233       +4     
- Partials     2244     2246       +2
Impacted Files Coverage Δ
packages/osd-i18n/src/core/locales.js 100.00% <100.00%> (ø)
...s/osd-optimizer/src/node/node_auto_tranpilation.ts 83.67% <0.00%> (-4.09%) ⬇️
packages/osd-optimizer/src/node/cache.ts 50.00% <0.00%> (-2.64%) ⬇️
...ic/application/models/sense_editor/sense_editor.ts 64.88% <0.00%> (-0.89%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@joshuarrrr joshuarrrr merged commit 575863c into opensearch-project:main Nov 22, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 23, 2022
@github-actions
[i18n] Register ru, ru-RU locale (#2817)
fc7275c 
* register ru locale

Signed-off-by: Dmitry Dudin <d_dudin@step.ru>
(cherry picked from commit 575863c)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Nov 23, 2022
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 23, 2022
@github-actions
[i18n] Register ru, ru-RU locale (#2817)
7bdae33 
* register ru locale

Signed-off-by: Dmitry Dudin <d_dudin@step.ru>
(cherry picked from commit 575863c)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Nov 23, 2022
Merged
@kavilla kavilla mentioned this pull request Nov 28, 2022
Closed
kavilla pushed a commit that referenced this pull request Dec 1, 2022
@opensearch-trigger-bot @github-actions
[i18n] Register ru, ru-RU locale (#2817) (#2920)
9e89a88 
* register ru locale

Signed-off-by: Dmitry Dudin <d_dudin@step.ru>
(cherry picked from commit 575863c)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kavilla pushed a commit that referenced this pull request Dec 5, 2022
@opensearch-trigger-bot @github-actions
[i18n] Register ru, ru-RU locale (#2817) (#2919)
fe778b5 
* register ru locale

Signed-off-by: Dmitry Dudin <d_dudin@step.ru>
(cherry picked from commit 575863c)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AlexRuiz7 pushed a commit to wazuh/wazuh-dashboard that referenced this pull request Dec 14, 2022
@dmitry-by-step-logic @AlexRuiz7
[i18n] Register ru, ru-RU locale (opensearch-project#2817)
574e912 
* register ru locale

Signed-off-by: Dmitry Dudin <d_dudin@step.ru>
AlexRuiz7 pushed a commit to wazuh/wazuh-dashboard that referenced this pull request Dec 14, 2022
@dmitry-by-step-logic @AlexRuiz7
[i18n] Register ru, ru-RU locale (opensearch-project#2817)
fffa7cd 
* register ru locale

Signed-off-by: Dmitry Dudin <d_dudin@step.ru>
sipopo pushed a commit to sipopo/OpenSearch-Dashboards that referenced this pull request Dec 16, 2022
@dmitry-by-step-logic @sipopo
[i18n] Register ru, ru-RU locale (opensearch-project#2817)
344e520 
* register ru locale

Signed-off-by: Dmitry Dudin <d_dudin@step.ru>
Signed-off-by: Sergey Osipov <sipopo@yandex.ru>
Arpit-Bandejiya pushed a commit to Arpit-Bandejiya/OpenSearch-Dashboards that referenced this pull request Jan 13, 2023
@dmitry-by-step-logic @Arpit-Bandejiya
[i18n] Register ru, ru-RU locale (opensearch-project#2817)
0ddeacb 
* register ru locale

Signed-off-by: Dmitry Dudin <d_dudin@step.ru>
Signed-off-by: Arpit Bandejiya <abandeji@amazon.com>
@aoguan1990 aoguan1990 mentioned this pull request Feb 2, 2023
Merged
8 tasks
@ananzh ananzh added v1.3.9 and removed v1.3.8 labels Feb 2, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 7, 2023
@github-actions
[i18n] Register ru, ru-RU locale (#2817) (#2919)
a1e7012 
* register ru locale

Signed-off-by: Dmitry Dudin <d_dudin@step.ru>
(cherry picked from commit 575863c)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit fe778b5)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
abbyhu2000 pushed a commit that referenced this pull request Mar 7, 2023
@opensearch-trigger-bot @github-actions
[i18n] Register ru, ru-RU locale (#2817) (#2919) (#3540)
994cad8 
* register ru locale


(cherry picked from commit 575863c)


# Conflicts:
#	CHANGELOG.md


(cherry picked from commit fe778b5)

Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
sikhote pushed a commit to sikhote/OpenSearch-Dashboards that referenced this pull request Apr 24, 2023
@dmitry-by-step-logic @sikhote
[i18n] Register ru, ru-RU locale (opensearch-project#2817)
c47fa4b 
* register ru locale

Signed-off-by: Dmitry Dudin <d_dudin@step.ru>
Signed-off-by: David Sinclair <david@sinclair.tech>
sikhote pushed a commit to sikhote/OpenSearch-Dashboards that referenced this pull request Apr 24, 2023
@dmitry-by-step-logic @sikhote
[i18n] Register ru, ru-RU locale (opensearch-project#2817)
5ea903a 
* register ru locale

Signed-off-by: Dmitry Dudin <d_dudin@step.ru>
Signed-off-by: David Sinclair <david@sinclair.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuarrrr joshuarrrr joshuarrrr approved these changes

@kristenTian kristenTian kristenTian approved these changes

@ananzh ananzh ananzh left review comments

Assignees
No one assigned
Labels
backport 2.x i18n Internationalization related Issues and PRs v1.3.9 v2.5.0 'Issues and PRs related to version v2.5.0'
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@dmitry-by-step-logic @ashwin-pc @ananzh @codecov-commenter @joshuarrrr @kristenTian