Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Version to 1.0.0 #292

Merged
merged 1 commit into from
Apr 15, 2021
Merged

Conversation

mihirsoni
Copy link
Contributor

@mihirsoni mihirsoni commented Apr 15, 2021

Signed-off-by: Mihir Soni mihirsoni.123@gmail.com

Description

[Describe what this change achieves] This change will reset the version of Dashboards to 1.0.0. This will be going to main branch as of now more details on this opensearch-project/OpenSearch#95 (comment)

  • All unit test cases passes.
  • All integration test pases.
  • FTR is still pending.
Testing

In order to test this

  • Clone this branch opensearch
  • ./gradlew :distribution:archives:oss-linux-tar:assemble
  • Use generated distribution to start the OpenSearch
  • Start dashbaords.

Issues Resolved

[List any issues this PR will resolve] #226

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com>
@mihirsoni mihirsoni added build Build related additions or modifications versioning labels Apr 15, 2021
@mihirsoni mihirsoni added this to the Beta release milestone Apr 15, 2021
@mihirsoni mihirsoni added this to Needs Review in Dashboards Core via automation Apr 15, 2021
@odfe-release-bot
Copy link

✅   DCO Check Passed 7dbca0c

Copy link
Contributor

@nknize nknize left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Dashboards Core automation moved this from Needs Review to Reviewer approved Apr 15, 2021
Copy link
Member

@kavilla kavilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Pulled it down all working fine with me! I see some exceptions on the service side but nothing blocking Dashboards from working from smoke tests.

@peterzhuamazon
Copy link
Member

start dco check

@odfe-release-bot
Copy link

✅   DCO Check Passed 7dbca0c

Copy link
Contributor

@boktorbb boktorbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and it seems to be working fine. Looks good

@mihirsoni
Copy link
Contributor Author

Waiting for this PR to be merged opensearch-project/OpenSearch#555

@mihirsoni
Copy link
Contributor Author

@nknize feel free to let us know / merge this PR whenever you have merged OpenSearch PR

@nknize nknize merged commit 9a2d3e6 into opensearch-project:main Apr 15, 2021
Dashboards Core automation moved this from Reviewer approved to Done Apr 15, 2021
@Madvinking
Copy link

will this work with migrating index-pattern?

kavilla pushed a commit that referenced this pull request May 21, 2021
This commit rebases the versioning to OpenSearch-Dashboards 1.0.0

Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Build related additions or modifications versioning
Projects
Development

Successfully merging this pull request may close these issues.

None yet

8 participants