Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 1.3] Corrects the usage of leaflet-vega parameters #3011

Merged
merged 1 commit into from
Dec 2, 2022
Merged

[Backport 1.3] Corrects the usage of leaflet-vega parameters #3011

merged 1 commit into from
Dec 2, 2022

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 94e7584 from #3005.

@github-actions
Corrects the usage of leaflet-vega parameters (#3005)
7949fb8 
Fixes #2996, #2353

- Bump `leaflet-vega` to `^0.9.0` - they merged in our upstream PR and made a release
- Fix the parameter name for passing `vega.parse` options.

Signed-off-by: Miki <miki@amazon.com>
(cherry picked from commit 94e7584)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
@AMoo-Miki AMoo-Miki added autocut Skip the changelog verification check on backports v1.3.7 labels Dec 2, 2022
@peterzhuamazon peterzhuamazon mentioned this pull request Dec 2, 2022
Closed
40 tasks
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (1.3@55a8bea). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 94e7584 differs from pull request most recent head 7949fb8. Consider uploading reports for the commit 7949fb8 to get more accurate results

@@          Coverage Diff           @@
##             1.3    #3011   +/-   ##
======================================
  Coverage       ?   66.73%           
======================================
  Files          ?     3219           
  Lines          ?    61450           
  Branches       ?     9417           
======================================
  Hits           ?    41009           
  Misses         ?    18202           
  Partials       ?     2239
Flag Coverage Δ
Linux 66.67% <0.00%> (?)
Windows 66.68% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@CEHENKLE CEHENKLE merged commit ce5db11 into 1.3 Dec 2, 2022
@github-actions github-actions bot deleted the backport/backport-3005-to-1.3 branch December 2, 2022 22:43
@joshuarrrr joshuarrrr removed the v1.3.7 label Dec 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AMoo-Miki AMoo-Miki AMoo-Miki approved these changes

@peterzhuamazon peterzhuamazon peterzhuamazon approved these changes

Assignees
No one assigned
Labels
autocut Skip the changelog verification check on backports v1.3.7
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@codecov-commenter @AMoo-Miki @peterzhuamazon @joshuarrrr @CEHENKLE