[Backport 1.x] Add Windows CI to the GitHub workflow #3290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please see #3128 (review) |
|
we want to backport the renaming of the file? |
Are you suggesting that we also want the rename backported? If so, I agree that the answer is "yes". Having the workflow files have the same name would make other backport changes easier. |
Here it is #3293 |
AMoo-Miki
previously approved these changes
Jan 19, 2023
joshuarrrr
previously approved these changes
Jan 19, 2023
manasvinibs
dismissed stale reviews from joshuarrrr and AMoo-Miki
via
4c454ea
manasvinibs
force-pushed
the
backport/backport-2966-to-1.x
branch
from
a024c5c
to
4c454ea
Compare
joshuarrrr
previously approved these changes
Jan 19, 2023
Signed-off-by: Manasvini B Suryanarayana <manasvis@amazon.com>
manasvinibs
force-pushed
the
backport/backport-2966-to-1.x
branch
from
4c454ea
to
bf2c0cb
Compare
AMoo-Miki
approved these changes
Jan 19, 2023
joshuarrrr
approved these changes
Jan 19, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 20, 2023
Signed-off-by: Manasvini B Suryanarayana <manasvis@amazon.com> Signed-off-by: Manasvini B Suryanarayana <manasvis@amazon.com> (cherry picked from commit 5f983c8) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
ananzh
pushed a commit
that referenced
this pull request
Jan 23, 2023
Signed-off-by: Manasvini B Suryanarayana <manasvis@amazon.com> Signed-off-by: Manasvini B Suryanarayana <manasvis@amazon.com> (cherry picked from commit 5f983c8) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Manasvini B Suryanarayana manasvis@amazon.com
Description
Manual backport of the #2966
Issues Resolved
Fixes #2451
Check List
yarn test:jestyarn test:jest_integrationyarn test:ftr