Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [search telemetry] Fixes search telemetry's observable object that won't be GC-ed #3422

Merged
merged 1 commit into from
Feb 15, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 7794b62 from #3390.

…n't be GC-ed (#3390)

The search telemetry was disabled by default, there is a issue when search telemetry read configuration and creates an Observable object that won't be GC-ed.

Signed-off-by: Tao Liu <liutaoaz@amazon.com>
(cherry picked from commit 7794b62)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team as a code owner February 13, 2023 20:33
@kavilla kavilla added the autocut Skip the changelog verification check on backports label Feb 13, 2023
@codecov-commenter
Copy link

codecov-commenter commented Feb 13, 2023

Codecov Report

Merging #3422 (41844f7) into 2.x (61aaede) will not change coverage.
The diff coverage is 33.33%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##              2.x    #3422   +/-   ##
=======================================
  Coverage   66.55%   66.55%           
=======================================
  Files        3203     3203           
  Lines       61330    61330           
  Branches     9453     9453           
=======================================
  Hits        40818    40818           
  Misses      18256    18256           
  Partials     2256     2256           
Flag Coverage Δ
Linux 66.50% <33.33%> (+<0.01%) ⬆️
Windows 66.50% <33.33%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/plugins/data/server/plugin.ts 0.00% <0.00%> (ø)
src/plugins/data/server/search/collectors/usage.ts 22.72% <ø> (-3.36%) ⬇️
src/plugins/data/server/search/search_service.ts 41.66% <50.00%> (+1.24%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@kristenTian kristenTian merged commit e025cc1 into 2.x Feb 15, 2023
@github-actions github-actions bot deleted the backport/backport-3390-to-2.x branch February 15, 2023 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut Skip the changelog verification check on backports v2.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants