Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MAINTAINERS.md and CODEOWNERS #3792

Merged
merged 1 commit into from
Apr 12, 2023

Conversation

ananzh
Copy link
Member

@ananzh ananzh commented Apr 5, 2023

Issues Resolved

#3426

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@ananzh ananzh added backport 2.x Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry labels Apr 5, 2023
@ananzh ananzh requested a review from a team as a code owner April 5, 2023 23:20
Issue Resolve
opensearch-project#3426

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
@codecov-commenter
Copy link

codecov-commenter commented Apr 6, 2023

Codecov Report

Merging #3792 (dd84c1c) into main (ce5c8cc) will decrease coverage by 0.05%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #3792      +/-   ##
==========================================
- Coverage   66.43%   66.38%   -0.05%     
==========================================
  Files        3209     3209              
  Lines       61673    61673              
  Branches     9521     9521              
==========================================
- Hits        40971    40941      -30     
- Misses      18421    18446      +25     
- Partials     2281     2286       +5     
Flag Coverage Δ
Linux 66.38% <ø> (+<0.01%) ⬆️
Windows ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 8 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@joshuarrrr joshuarrrr merged commit ccac24e into opensearch-project:main Apr 12, 2023
13 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 1.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-1.x 1.x
# Navigate to the new working tree
pushd ../.worktrees/backport-1.x
# Create a new branch
git switch --create backport/backport-3792-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 ccac24e4c3e4cfeba514ff378842c58b9445c0c6
# Push it to GitHub
git push --set-upstream origin backport/backport-3792-to-1.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-1.x

Then, create a pull request where the base branch is 1.x and the compare/head branch is backport/backport-3792-to-1.x.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 1.3 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-1.3 1.3
# Navigate to the new working tree
pushd ../.worktrees/backport-1.3
# Create a new branch
git switch --create backport/backport-3792-to-1.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 ccac24e4c3e4cfeba514ff378842c58b9445c0c6
# Push it to GitHub
git push --set-upstream origin backport/backport-3792-to-1.3
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-1.3

Then, create a pull request where the base branch is 1.3 and the compare/head branch is backport/backport-3792-to-1.3.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-3792-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 ccac24e4c3e4cfeba514ff378842c58b9445c0c6
# Push it to GitHub
git push --set-upstream origin backport/backport-3792-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-3792-to-2.x.

opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 18, 2023
Issue Resolve
#3426

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
(cherry picked from commit ccac24e)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
joshuarrrr pushed a commit that referenced this pull request Apr 19, 2023
Issue Resolve
#3426


(cherry picked from commit ccac24e)

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 19, 2023
Issue Resolve
#3426

(cherry picked from commit ccac24e)

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 978bd7b)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot
Copy link
Contributor

The backport to 1.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-1.x 1.x
# Navigate to the new working tree
pushd ../.worktrees/backport-1.x
# Create a new branch
git switch --create backport/backport-3792-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 ccac24e4c3e4cfeba514ff378842c58b9445c0c6
# Push it to GitHub
git push --set-upstream origin backport/backport-3792-to-1.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-1.x

Then, create a pull request where the base branch is 1.x and the compare/head branch is backport/backport-3792-to-1.x.

joshuarrrr pushed a commit that referenced this pull request Apr 19, 2023
Issue Resolve
#3426

(cherry picked from commit ccac24e)

(cherry picked from commit 978bd7b)

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
joshuarrrr pushed a commit to joshuarrrr/OpenSearch-Dashboards that referenced this pull request Apr 19, 2023
Issue Resolve
opensearch-project#3426

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
(cherry picked from commit ccac24e)
@ananzh
Copy link
Member Author

ananzh commented Apr 20, 2023

@gaiksaya could you help us to double check the permissions? If they are not correct, pls help to update them because we don't have admin permission. thx.

@gaiksaya
Copy link
Member

Permissions are updated now. See snapshot here #3426 (comment)

@ananzh
Copy link
Member Author

ananzh commented Apr 20, 2023

@gaiksaya thank you so much.

sikhote pushed a commit to sikhote/OpenSearch-Dashboards that referenced this pull request Apr 24, 2023
Issue Resolve
opensearch-project#3426

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
Signed-off-by: David Sinclair <david@sinclair.tech>
ashwin-pc pushed a commit that referenced this pull request Apr 24, 2023
Issue Resolve
#3426

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
(cherry picked from commit ccac24e)

Co-authored-by: Anan Zhuang <ananzh@amazon.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 24, 2023
Issue Resolve
#3426

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
(cherry picked from commit ccac24e)

Co-authored-by: Anan Zhuang <ananzh@amazon.com>
(cherry picked from commit 034e983)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
manasvinibs pushed a commit that referenced this pull request Apr 26, 2023
Issue Resolve
#3426


(cherry picked from commit ccac24e)


(cherry picked from commit 034e983)

Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Anan Zhuang <ananzh@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.3 backport 2.x Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry v1.3.10 v2.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants