Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Manual Backport 1.3] Add tooltip to help icon (#3626) #3872

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
- Temporary workaround for task-kill exceptions on Windows when it is passed a pid for a process that is already dead ([#2842](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2842))
- [Build] Fixed "Last Access Time" not being set by `scanCopy` on Windows ([#2964](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2964))
- Update `leaflet-vega` and fix its usage ([#3005](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3005))
- Add clarifying tooltips to header navigation ([#3573](https://github.com/opensearch-project/OpenSearch-Dashboards/issues/3573))

### 🚞 Infrastructure

Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 7 additions & 1 deletion src/core/public/chrome/ui/header/header.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,13 @@ export function Header({
aria-controls={navId}
ref={toggleCollapsibleNavRef}
>
<EuiIcon type="menu" size="m" />
<EuiIcon
type="menu"
size="m"
title={i18n.translate('core.ui.primaryNav.menu', {
defaultMessage: 'Menu',
})}
/>
</EuiHeaderSectionItemButton>
</EuiHeaderSectionItem>

Expand Down
10 changes: 9 additions & 1 deletion src/core/public/chrome/ui/header/header_help_menu.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -330,7 +330,15 @@ class HeaderHelpMenuUI extends Component<Props, State> {
})}
onClick={this.onMenuButtonClick}
>
<EuiIcon type="help" size="m" />
<EuiIcon type="questionInCircle" size="m" />
<EuiIcon
type="help"
size="m"
title={intl.formatMessage({
id: 'core.ui.chrome.headerGlobalNav.helpMenuButtonTitle',
defaultMessage: 'Help',
})}
/>
</EuiHeaderSectionItemButton>
);

Expand Down