-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump OUI dependency to 1.2.0 cherry-pick #4337
Bump OUI dependency to 1.2.0 cherry-pick #4337
Conversation
Signed-off-by: Josh Romero <rmerqg@amazon.com>
Signed-off-by: Josh Romero <rmerqg@amazon.com>
Signed-off-by: Josh Romero <rmerqg@amazon.com>
Signed-off-by: Josh Romero <rmerqg@amazon.com>
Now that the breacrumb styling is updated in OUI v1.2.0 Signed-off-by: Josh Romero <rmerqg@amazon.com>
Essentially reverting: - opensearch-project#1954 - opensearch-project#2085 Signed-off-by: Josh Romero <rmerqg@amazon.com>
Signed-off-by: Josh Romero <rmerqg@amazon.com>
If this is only needed to ensure testing in a test cluster, can we have this pointed to a different test branch? I'm afraid of merging this change in here can lead to complications when merging back into main/2.x if the source PR isn't merged yet, or has changes that could cause conflicts |
Codecov Report
@@ Coverage Diff @@
## feature/feature-anywhere #4337 +/- ##
============================================================
- Coverage 66.36% 66.36% -0.01%
============================================================
Files 3271 3271
Lines 62997 62996 -1
Branches 9758 9757 -1
============================================================
- Hits 41811 41809 -2
- Misses 18840 18841 +1
Partials 2346 2346
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving so you have the option of merging if necessary. I plan to cut a 1.1.1 release of OUI that is limited to the icon change so that it will definitely be available.
Description
Cherry pick of #4170
Issues Resolved
N/A
Testing the changes
Manual local testing
Check List
yarn test:jest
yarn test:jest_integration
yarn test:ftr