Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Enable data client with sample data server side #4340

Merged
merged 1 commit into from
Jun 22, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport b337bea from #4268.

@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Merging #4340 (e5d01fa) into 2.x (b00edec) will increase coverage by 0.01%.
The diff coverage is 79.56%.

@@            Coverage Diff             @@
##              2.x    #4340      +/-   ##
==========================================
+ Coverage   66.39%   66.40%   +0.01%     
==========================================
  Files        3229     3245      +16     
  Lines       62141    62400     +259     
  Branches     9627     9663      +36     
==========================================
+ Hits        41256    41435     +179     
- Misses      18561    18625      +64     
- Partials     2324     2340      +16     
Flag Coverage Δ
Linux 66.34% <79.56%> (+0.03%) ⬆️
Windows 66.34% <79.56%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../services/sample_data/data_sets/ecommerce/index.ts 75.00% <66.66%> (ø)
...erver/services/sample_data/data_sets/logs/index.ts 75.00% <66.66%> (ø)
...ns/home/server/services/sample_data/routes/list.ts 59.45% <66.66%> (ø)
...home/server/services/sample_data/data_sets/util.ts 79.41% <79.41%> (ø)
...home/server/services/sample_data/routes/install.ts 67.16% <93.33%> (ø)
...gins/data_source/server/client/configure_client.ts 71.42% <100.00%> (ø)
...ta_source/server/legacy/configure_legacy_client.ts 71.15% <100.00%> (ø)
...er/services/sample_data/data_sets/flights/index.ts 100.00% <100.00%> (ø)
...me/server/services/sample_data/routes/uninstall.ts 76.19% <100.00%> (ø)

... and 11 files with indirect coverage changes

* Enable data client with sample data server side

* Add dataSourceId into savedObject

Signed-off-by: Kristen Tian <tyarong@amazon.com>

* Functional list, install uninstall

Signed-off-by: Kristen Tian <tyarong@amazon.com>

* add change log

Signed-off-by: Kristen Tian <tyarong@amazon.com>

* address comments

Signed-off-by: Kristen Tian <tyarong@amazon.com>

* add ut

Signed-off-by: Kristen Tian <tyarong@amazon.com>

---------

Signed-off-by: Kristen Tian <tyarong@amazon.com>
(cherry picked from commit b337bea)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
@kristenTian kristenTian force-pushed the backport/backport-4268-to-2.x branch from ba48404 to e5d01fa Compare June 22, 2023 18:52
@kristenTian kristenTian merged commit 4fbf897 into 2.x Jun 22, 2023
42 of 44 checks passed
@github-actions github-actions bot deleted the backport/backport-4268-to-2.x branch June 22, 2023 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants