Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Add fonts for previewing the Next theme #4449

Merged
merged 1 commit into from
Jun 30, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 63b66f9 from #4381.

Also:
* Expose default font-family values as CSS variables
* Make default fonts load from OSD and not OUI
* Make fonts differentiable across themes
* Use the theme font in the Legacy Editor

Signed-off-by: Miki <miki@amazon.com>
Co-authored-by: Josh Romero <rmerqg@amazon.com>
(cherry picked from commit 63b66f9)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
@codecov
Copy link

codecov bot commented Jun 30, 2023

Codecov Report

Merging #4449 (0ee8877) into 2.x (b6f0d80) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##              2.x    #4449   +/-   ##
=======================================
  Coverage   66.42%   66.42%           
=======================================
  Files        3246     3246           
  Lines       62443    62450    +7     
  Branches     9671     9674    +3     
=======================================
+ Hits        41477    41484    +7     
  Misses      18621    18621           
  Partials     2345     2345           
Flag Coverage Δ
Linux 66.37% <100.00%> (+<0.01%) ⬆️
Windows 66.37% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/core/server/rendering/views/template.tsx 100.00% <ø> (ø)
src/core/server/rendering/rendering_service.tsx 66.66% <100.00%> (+0.43%) ⬆️
src/core/server/rendering/views/fonts.tsx 100.00% <100.00%> (ø)

@AMoo-Miki AMoo-Miki merged commit a7a35a6 into 2.x Jun 30, 2023
61 of 63 checks passed
@github-actions github-actions bot deleted the backport/backport-4381-to-2.x branch June 30, 2023 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut Skip the changelog verification check on backports distinguished-contributor v2.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants