Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.9] [Backport 2.x] [Vis Augmenter Add UT for few fns #4544

Merged
merged 1 commit into from
Jul 11, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 4f0a575 from #4534.

* Add UT for few fns
* add changelog entry

---------

Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
(cherry picked from commit 1dc1060)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 4f0a575)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Merging #4544 (0540e82) into 2.9 (898410d) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              2.9    #4544      +/-   ##
==========================================
+ Coverage   66.44%   66.49%   +0.04%     
==========================================
  Files        3288     3288              
  Lines       63288    63284       -4     
  Branches     9846     9846              
==========================================
+ Hits        42051    42078      +27     
+ Misses      18857    18827      -30     
+ Partials     2380     2379       -1     
Flag Coverage Δ
Linux 66.43% <100.00%> (+0.04%) ⬆️
Windows 66.43% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/plugins/vis_augmenter/public/vega/helpers.ts 98.50% <ø> (+19.83%) ⬆️
src/plugins/vis_augmenter/public/utils/utils.ts 96.55% <100.00%> (+6.55%) ⬆️

@kavilla kavilla merged commit 01e7aa3 into 2.9 Jul 11, 2023
65 of 67 checks passed
@github-actions github-actions bot deleted the backport/backport-4534-to-2.9 branch July 11, 2023 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
all-star-contributor autocut Skip the changelog verification check on backports feature-anywhere v2.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants