Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Removed KUI usage in maps_legacy plugin #4592

Merged
merged 1 commit into from
Jul 25, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 22a8943 from #3998.

* Removed KUI usage from map_legacy plugin

Signed-off-by: Malika Shamgunova <malika.shamgun@gmail.com>

* Removed KUI icon from maps_legacy plugin

Signed-off-by: Malika Shamgunova <malika.shamgun@gmail.com>

* import

Signed-off-by: Malika Shamgunova <malika.shamgun@gmail.com>

* Added to CHNAGELOG.md

Signed-off-by: Malika Shamgunova <malika.shamgun@gmail.com>

* Updated CHANGELOG.md

Signed-off-by: Malika Shamgunova <malika.shamgun@gmail.com>

* Update in CHANGELOG.md

Signed-off-by: Malika Shamgunova <malika.shamgun@gmail.com>

* Upgrade the backport workflow (#4343)

* Copy over the labels from the original PR
* Label the backport PR with `autocut`
* Label a PR that fails to backport

Signed-off-by: Miki <miki@amazon.com>

* Hide any output from `use_node` checking for Node compatibility (#4237)

Signed-off-by: Miki <miki@amazon.com>
Signed-off-by: Josh Romero <rmerqg@amazon.com>
Co-authored-by: Josh Romero <rmerqg@amazon.com>

* Resolved merge conflicts

Signed-off-by: Malika Shamgunova <malika.shamgun@gmail.com>

* Apply suggestions from code review

Resolve changelog conflicts

Signed-off-by: Josh Romero <rmerqg@amazon.com>

---------

Signed-off-by: Malika Shamgunova <malika.shamgun@gmail.com>
Signed-off-by: Anan Zhuang <ananzh@amazon.com>
Signed-off-by: Miki <miki@amazon.com>
Signed-off-by: Josh Romero <rmerqg@amazon.com>
Co-authored-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
Co-authored-by: Anan Zhuang <ananzh@amazon.com>
Co-authored-by: Miki <miki@amazon.com>
Co-authored-by: Josh Romero <rmerqg@amazon.com>
(cherry picked from commit 22a8943)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Merging #4592 (41a67cd) into 2.x (4e82ca8) will decrease coverage by 11.00%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##              2.x    #4592       +/-   ##
===========================================
- Coverage   66.16%   55.17%   -11.00%     
===========================================
  Files        3315     3017      -298     
  Lines       63892    59767     -4125     
  Branches     9961     9329      -632     
===========================================
- Hits        42277    32976     -9301     
- Misses      19250    24725     +5475     
+ Partials     2365     2066      -299     
Flag Coverage Δ
Linux_1 ?
Linux_2 ?
Linux_3 ?
Linux_4 ?
Windows_1 34.76% <ø> (ø)
Windows_2 ?
Windows_3 43.23% <ø> (ø)
Windows_4 35.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...aps_legacy/public/map/opensearch_dashboards_map.js 25.62% <ø> (ø)

... and 698 files with indirect coverage changes

Copy link
Member

@joshuarrrr joshuarrrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

codecov must be out of its machine mind.

@joshuarrrr joshuarrrr merged commit 1c9c536 into 2.x Jul 25, 2023
70 of 73 checks passed
@joshuarrrr joshuarrrr deleted the backport/backport-3998-to-2.x branch July 25, 2023 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut Skip the changelog verification check on backports first-time-contributor OSCI Open Source Contributor Initiative v2.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants