Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Refactor/remove breadcrumb styling main #4627

Merged
merged 1 commit into from
Jul 26, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 983fc34 from #4621.

* chore(chrome): Remove OSD breadcrumb styling and classes

Now that the breacrumb styling is coming from OUI

Signed-off-by: Josh Romero <rmerqg@amazon.com>

* chore (chrome): Remove other remnants of breadcrumb styling

Essentially reverting:
- #1954
- #2085

Signed-off-by: Josh Romero <rmerqg@amazon.com>

* Update snapshot

Signed-off-by: Josh Romero <rmerqg@amazon.com>

* add changelog

Signed-off-by: Josh Romero <rmerqg@amazon.com>

* Update header snapshot

Signed-off-by: Josh Romero <rmerqg@amazon.com>

---------

Signed-off-by: Josh Romero <rmerqg@amazon.com>
(cherry picked from commit 983fc34)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Merging #4627 (04d09be) into 2.x (d3163cf) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              2.x    #4627      +/-   ##
==========================================
- Coverage   66.10%   66.09%   -0.01%     
==========================================
  Files        3316     3316              
  Lines       63899    63898       -1     
  Branches    10124    10123       -1     
==========================================
- Hits        42242    42235       -7     
- Misses      19172    19253      +81     
+ Partials     2485     2410      -75     
Flag Coverage Δ
Linux_1 34.76% <0.00%> (+<0.01%) ⬆️
Linux_2 55.07% <100.00%> (+<0.01%) ⬆️
Linux_3 43.08% <0.00%> (-0.01%) ⬇️
Linux_4 35.09% <0.00%> (+<0.01%) ⬆️
Windows_1 34.77% <0.00%> (+<0.01%) ⬆️
Windows_2 55.03% <100.00%> (+<0.01%) ⬆️
Windows_3 43.09% <0.00%> (+<0.01%) ⬆️
Windows_4 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/core/public/chrome/ui/header/header.tsx 75.00% <100.00%> (ø)
...ore/public/chrome/ui/header/header_breadcrumbs.tsx 100.00% <100.00%> (+10.00%) ⬆️

... and 19 files with indirect coverage changes

@abbyhu2000 abbyhu2000 merged commit 0e0493a into 2.x Jul 26, 2023
69 of 71 checks passed
@github-actions github-actions bot deleted the backport/backport-4621-to-2.x branch July 26, 2023 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut Skip the changelog verification check on backports distinguished-contributor v2.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants