Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate duplicate dashboard breadcrumb text ID #4805

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

abbyhu2000
Copy link
Member

Description

Eliminate duplicate dashboard breadcrumb text ID

Issues Resolved

resolves #4794

Screenshot

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Merging #4805 (f932df1) into main (8e1ec99) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #4805   +/-   ##
=======================================
  Coverage   66.30%   66.30%           
=======================================
  Files        3322     3322           
  Lines       63923    63923           
  Branches    10117    10117           
=======================================
  Hits        42384    42384           
  Misses      19050    19050           
  Partials     2489     2489           
Flag Coverage Δ
Linux_1 34.84% <ø> (ø)
Linux_2 55.14% <ø> (ø)
Linux_3 43.39% <ø> (ø)
Linux_4 35.10% <ø> (ø)
Windows_1 34.85% <ø> (ø)
Windows_2 55.10% <ø> (ø)
Windows_3 43.40% <ø> (ø)
Windows_4 35.10% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
.../dashboard/public/application/utils/breadcrumbs.ts 100.00% <ø> (ø)

@curq curq merged commit 0aa1124 into opensearch-project:main Aug 24, 2023
59 of 75 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 24, 2023
Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
(cherry picked from commit 0aa1124)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@curq curq mentioned this pull request Sep 1, 2023
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x distinguished-contributor Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Duplicate message IDs with default messages
3 participants