Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data Explorer][Discover 2.0] Add missing change interval on TimeChart and improve fetch #4850

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

ananzh
Copy link
Member

@ananzh ananzh commented Aug 29, 2023

Note

This PR is blocked by #4806
We currently decide to move from feature branch to main for all following fixes. After #4806 is merged, I will rebase the PR and remove draft.

Issues Resolved

#4847

Description

Allow discover 2.0 histogram to update according to interval change.
Screenshot 2023-08-29 at 16 41 04

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@ananzh ananzh added bug Something isn't working discover for discover reinvent data explorer Issues related to the Data Explorer project v2.10.0 labels Aug 29, 2023
@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Merging #4850 (e07ae87) into main (03ae2bd) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #4850      +/-   ##
==========================================
- Coverage   66.46%   66.45%   -0.01%     
==========================================
  Files        3390     3390              
  Lines       64742    64743       +1     
  Branches    10312    10312              
==========================================
- Hits        43030    43028       -2     
- Misses      19169    19171       +2     
- Partials     2543     2544       +1     
Flag Coverage Δ
Linux_1 34.87% <0.00%> (-0.01%) ⬇️
Linux_2 55.15% <ø> (ø)
Linux_3 44.18% <0.00%> (-0.01%) ⬇️
Linux_4 35.04% <ø> (ø)
Windows_1 34.88% <0.00%> (-0.01%) ⬇️
Windows_2 55.12% <ø> (ø)
Windows_3 44.18% <0.00%> (-0.01%) ⬇️
Windows_4 35.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...lication/utils/state_management/discover_slice.tsx 46.87% <0.00%> (-1.52%) ⬇️

... and 1 file with indirect coverage changes

…t and improve fetch

Issue Resolve
opensearch-project#4847

Signed-off-by: ananzh <ananzh@amazon.com>
@ananzh ananzh force-pushed the discover-fix-chart-interval branch from 42a3123 to e07ae87 Compare August 30, 2023 16:48
@ananzh ananzh marked this pull request as ready for review August 30, 2023 16:48
@ashwin-pc ashwin-pc added the Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry label Aug 30, 2023
@ananzh ananzh merged commit a239fc2 into opensearch-project:main Aug 30, 2023
54 of 72 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-4850-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a239fc204d9b505e800054a7eae27d2ebe939d00
# Push it to GitHub
git push --set-upstream origin backport/backport-4850-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-4850-to-2.x.

ashwin-pc pushed a commit to ashwin-pc/OpenSearch-Dashboards that referenced this pull request Aug 31, 2023
…t and improve fetch (opensearch-project#4850)

Issue Resolve
opensearch-project#4847

Signed-off-by: ananzh <ananzh@amazon.com>
(cherry picked from commit a239fc2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x bug Something isn't working data explorer Issues related to the Data Explorer project discover for discover reinvent distinguished-contributor Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry v2.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants