Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data Explorer][Discover 2.0] Append popout icon to oui link for doc viewer links #4855

Merged
merged 2 commits into from
Aug 31, 2023

Conversation

ananzh
Copy link
Member

@ananzh ananzh commented Aug 30, 2023

Issues Resolved

#4825

Screenshot

Screenshot 2023-08-30 at 11 20 11

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@ashwin-pc ashwin-pc added backport 2.x discover for discover reinvent data explorer Issues related to the Data Explorer project v2.10.0 Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry labels Aug 30, 2023
@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Merging #4855 (26acb3e) into main (2738131) will decrease coverage by 0.02%.
Report is 2 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4855      +/-   ##
==========================================
- Coverage   66.43%   66.42%   -0.02%     
==========================================
  Files        3396     3396              
  Lines       64865    64869       +4     
  Branches    10357    10358       +1     
==========================================
- Hits        43096    43092       -4     
- Misses      19209    19217       +8     
  Partials     2560     2560              
Flag Coverage Δ
Linux_1 34.84% <ø> (-0.02%) ⬇️
Linux_2 55.15% <ø> (ø)
Linux_3 44.24% <ø> (?)
Linux_4 35.04% <ø> (ø)
Windows_1 34.87% <ø> (ø)
Windows_2 55.12% <ø> (ø)
Windows_3 44.24% <ø> (-0.01%) ⬇️
Windows_4 35.04% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...n/components/doc_viewer_links/doc_viewer_links.tsx 100.00% <ø> (ø)

... and 5 files with indirect coverage changes

…viewer links

Issue Resolve
opensearch-project#4825

Signed-off-by: ananzh <ananzh@amazon.com>
Signed-off-by: ananzh <ananzh@amazon.com>
@ashwin-pc ashwin-pc merged commit e9ad10f into opensearch-project:main Aug 31, 2023
54 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-4855-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e9ad10ffb22f358e05d883f9ad8998e169e45fd0
# Push it to GitHub
git push --set-upstream origin backport/backport-4855-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-4855-to-2.x.

ashwin-pc pushed a commit to ashwin-pc/OpenSearch-Dashboards that referenced this pull request Aug 31, 2023
…viewer links (opensearch-project#4855)

* [Data Explorer][Discover 2.0] Append popout icon to oui link for doc viewer links

Issue Resolve
opensearch-project#4825

Signed-off-by: ananzh <ananzh@amazon.com>

* fix all failed ut

Signed-off-by: ananzh <ananzh@amazon.com>

---------

Signed-off-by: ananzh <ananzh@amazon.com>
(cherry picked from commit e9ad10f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x data explorer Issues related to the Data Explorer project discover for discover reinvent distinguished-contributor Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry v2.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants