[Data Explorer] Add dismissible callout for discover #4857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
abbyhu2000
added
backport 2.x
data explorer
abbyhu2000
requested review from
ananzh,
kavilla,
seanneumann,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
zengyan-amazon,
kristenTian,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
BSFishy and
curq
as code owners
8 tasks
abbyhu2000
added
the
ux / ui
Codecov Report
@@ Coverage Diff @@
## main #4857 +/- ##
==========================================
- Coverage 66.46% 66.43% -0.03%
==========================================
Files 3390 3396 +6
Lines 64742 64869 +127
Branches 10312 10356 +44
==========================================
+ Hits 43030 43095 +65
- Misses 19169 19215 +46
- Partials 2543 2559 +16
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
ashwin-pc
reviewed
Aug 30, 2023
CHANGELOG.md
Outdated
| @@ -279,6 +279,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) | |||
| - Temporarily hardcode chromedriver to 112.0.0 to enable all ftr tests ([#4039](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/4039)) | |||
| - Update MAINTAINERS.md and CODEOWNERS ([#3938](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3938)) | |||
| - Add opensearch-dashboards-docker-dev to .gitignore ([#3781](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3781)) | |||
| - [Data Explorer] Add dismissible callout for discover ([#4857](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/4857)) | |||
There was a problem hiding this comment.
Can you remove this? We dont need changelog entries for the Data Explorer PR's since i've already added on for introducing the feature
| title="You're viewing Discover 2.0. The old Discover app will be retired in OpenSearch version 2.11. To switch back to the old version, toggle the New Discover." | ||
| iconType="alert" | ||
| dismissible | ||
| onDismissible={closeCallOut} |
There was a problem hiding this comment.
oh, not sure how i missed this in theOUI PR but this should be onDismiss Think we can get that changed in a followup PR?
There was a problem hiding this comment.
Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
ashwin-pc
added
the
Skip-Changelog
ananzh
approved these changes
Aug 30, 2023
ashwin-pc
approved these changes
Aug 30, 2023
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-4857-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 58ee450a7a63277222a7e1361865f0c5a8eb5538
# Push it to GitHub
git push --set-upstream origin backport/backport-4857-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.xThen, create a pull request where the |
ashwin-pc
pushed a commit
to ashwin-pc/OpenSearch-Dashboards
that referenced
this pull request
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add callout for both legacy discover and data explorer to warn users.
Issues Resolved
Screenshot
Screen.Recording.2023-08-30.at.11.36.05.AM.mov
Testing the changes
Check List
yarn test:jestyarn test:jest_integrationyarn test:ftr