[Feature] Datasource selector of multiple datasources #5167

mengweieric · 2023-10-02T03:14:56Z

Description

Datasource selector support in OpenSearch Dashboard Discover

Issues Resolved

fixes #4482, #4991

Screenshot

Testing the changes

Check List

Signed-off-by: Eric <menwe@amazon.com>

…a plugin Signed-off-by: Eric <menwe@amazon.com>

Signed-off-by: Eric <menwe@amazon.com>

…ncements Signed-off-by: Eric <menwe@amazon.com>

Signed-off-by: Eric <menwe@amazon.com>

ashwin-pc

Just one last experimental label was missed, the rest look good.

src/plugins/data/public/data_sources/datasource/datasource.ts

ashwin-pc · 2023-10-05T23:09:48Z

src/plugins/data/public/data_sources/datasource_selector/datasource_selectable.tsx

+    const ip = dataSet as IndexPatternOption;
+    return {
+      ...optionContent,
+      label: ip.title,
+      value: ip.id,
+    };


Nit:

Suggested change

const ip = dataSet as IndexPatternOption;

return {

...optionContent,

label: ip.title,

value: ip.id,

};

return {

...optionContent,

label: dataSet.title,

value: dataSet.id,

};

ashwin-pc · 2023-10-05T23:48:10Z

src/plugins/data/public/data_sources/datasource_selector/datasource_selectable.tsx

+  onDataSourceSelect,
+  setDataSourceOptionList,
+  onGetDataSetError, //   onGetDataSetError, Callback for handling get data set errors. Ensure it's memoized.
+  singleSelection = true,


Suggested change

singleSelection = true,

singleSelection = { asPlainText: true },

Signed-off-by: Eric <menwe@amazon.com>

* initial commit for datasource Signed-off-by: Eric <menwe@amazon.com> * initial commit for datasource service Signed-off-by: Eric <menwe@amazon.com> * [Data Sources] Move datasource codebase from datasource plugin to data plugin Signed-off-by: Eric <menwe@amazon.com> * [Data Sources] Add datasource factory Signed-off-by: Eric <menwe@amazon.com> * datasource service Signed-off-by: Eric <menwe@amazon.com> * datasource with factory Signed-off-by: Eric <menwe@amazon.com> * datasource selector Signed-off-by: Eric <menwe@amazon.com> * exposes datasources from data plugin Signed-off-by: Eric <menwe@amazon.com> * index pattern datasource registration Signed-off-by: Eric <menwe@amazon.com> * add datasource selector to discover Signed-off-by: Eric <menwe@amazon.com> * remove unused files Signed-off-by: Eric <menwe@amazon.com> * add/exposes types for datasources as a set of services Signed-off-by: Eric <menwe@amazon.com> * add datasource selector unit tests Signed-off-by: Eric <menwe@amazon.com> * add metadata to selectable Signed-off-by: Eric <menwe@amazon.com> * redirection to observability for non-index-pattern datasource Signed-off-by: Eric <menwe@amazon.com> * add datasource factory tests Signed-off-by: Eric <menwe@amazon.com> * add datasource service test Signed-off-by: Eric <menwe@amazon.com> * datasources related fixes Signed-off-by: Eric <menwe@amazon.com> * add tests for datasource selectable Signed-off-by: Eric <menwe@amazon.com> * added types/interfaces for sidebar selector, and add a couple of enhancements Signed-off-by: Eric <menwe@amazon.com> * remove pill effect Signed-off-by: Eric <menwe@amazon.com> * change type for name display in selector for index patterns Signed-off-by: Eric <menwe@amazon.com> * remove legacy index selector Signed-off-by: Eric <menwe@amazon.com> * rename datasource change handler Signed-off-by: Eric <menwe@amazon.com> * remove unused constants Signed-off-by: Eric <menwe@amazon.com> * fix a redirection bug Signed-off-by: Eric <menwe@amazon.com> * add to change log Signed-off-by: Eric <menwe@amazon.com> * fix bg color issue in source selector Signed-off-by: Eric <menwe@amazon.com> * address oui and missing guard Signed-off-by: Eric <menwe@amazon.com> * add test subj Signed-off-by: Eric <menwe@amazon.com> * i18 and datasource interface default return Signed-off-by: Eric <menwe@amazon.com> * add default datasource tests Signed-off-by: Eric <menwe@amazon.com> * fix typo Signed-off-by: Eric <menwe@amazon.com> * modify wording Signed-off-by: Eric <menwe@amazon.com> * add experimental annotation to datasource Signed-off-by: Eric <menwe@amazon.com> * add type datasource filtering to remove type error hint Signed-off-by: Eric <menwe@amazon.com> * remove unused type Signed-off-by: Eric <menwe@amazon.com> * add 'type' to option type Signed-off-by: Eric <menwe@amazon.com> * Type fixes Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * cherry-pick type changes from remote and add partial fixes Signed-off-by: Eric <menwe@amazon.com> * add one type exports Signed-off-by: Eric <menwe@amazon.com> * remaining type errors fixed Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * addressing comments Signed-off-by: Eric <menwe@amazon.com> * address dedup Signed-off-by: Eric <menwe@amazon.com> * refactor datasource_selectable to address comments Signed-off-by: Joshua Li <joshuali925@gmail.com> * remove unnecessary optional chaining Signed-off-by: Joshua Li <joshuali925@gmail.com> * refactor variable names Signed-off-by: Joshua Li <joshuali925@gmail.com> * move functnions out of selectable component Signed-off-by: Eric <menwe@amazon.com> * add comments for dedup/options list updates Signed-off-by: Eric <menwe@amazon.com> * add experimental annotation Signed-off-by: Eric <menwe@amazon.com> * callback and experimental annotation on types Signed-off-by: Eric <menwe@amazon.com> * handleSourceSelection callback Signed-off-by: Eric <menwe@amazon.com> * datasource annotation and import adjustment Signed-off-by: Eric <menwe@amazon.com> * remove pill effect Signed-off-by: Eric <menwe@amazon.com> * minor changes addressing latest comments Signed-off-by: Eric <menwe@amazon.com> * remove unused tests Signed-off-by: Eric <menwe@amazon.com> --------- Signed-off-by: Eric <menwe@amazon.com> Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> Signed-off-by: Joshua Li <joshuali925@gmail.com> Co-authored-by: Josh Romero <rmerqg@amazon.com> Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com> Co-authored-by: Joshua Li <joshuali925@gmail.com> (cherry picked from commit 1e980fa) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* initial commit for datasource * initial commit for datasource service * [Data Sources] Move datasource codebase from datasource plugin to data plugin * [Data Sources] Add datasource factory * datasource service * datasource with factory * datasource selector * exposes datasources from data plugin * index pattern datasource registration * add datasource selector to discover * remove unused files * add/exposes types for datasources as a set of services * add datasource selector unit tests * add metadata to selectable * redirection to observability for non-index-pattern datasource * add datasource factory tests * add datasource service test * datasources related fixes * add tests for datasource selectable * added types/interfaces for sidebar selector, and add a couple of enhancements * remove pill effect * change type for name display in selector for index patterns * remove legacy index selector * rename datasource change handler * remove unused constants * fix a redirection bug * add to change log * fix bg color issue in source selector * address oui and missing guard * add test subj * i18 and datasource interface default return * add default datasource tests * fix typo * modify wording * add experimental annotation to datasource * add type datasource filtering to remove type error hint * remove unused type * add 'type' to option type * Type fixes * cherry-pick type changes from remote and add partial fixes * add one type exports * remaining type errors fixed * addressing comments * address dedup * refactor datasource_selectable to address comments * remove unnecessary optional chaining * refactor variable names * move functnions out of selectable component * add comments for dedup/options list updates * add experimental annotation * callback and experimental annotation on types * handleSourceSelection callback * datasource annotation and import adjustment * remove pill effect * minor changes addressing latest comments * remove unused tests --------- (cherry picked from commit 1e980fa) Signed-off-by: Eric <menwe@amazon.com> Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> Signed-off-by: Joshua Li <joshuali925@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Josh Romero <rmerqg@amazon.com> Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com> Co-authored-by: Joshua Li <joshuali925@gmail.com>

…ject#5167) * initial commit for datasource Signed-off-by: Eric <menwe@amazon.com> * initial commit for datasource service Signed-off-by: Eric <menwe@amazon.com> * [Data Sources] Move datasource codebase from datasource plugin to data plugin Signed-off-by: Eric <menwe@amazon.com> * [Data Sources] Add datasource factory Signed-off-by: Eric <menwe@amazon.com> * datasource service Signed-off-by: Eric <menwe@amazon.com> * datasource with factory Signed-off-by: Eric <menwe@amazon.com> * datasource selector Signed-off-by: Eric <menwe@amazon.com> * exposes datasources from data plugin Signed-off-by: Eric <menwe@amazon.com> * index pattern datasource registration Signed-off-by: Eric <menwe@amazon.com> * add datasource selector to discover Signed-off-by: Eric <menwe@amazon.com> * remove unused files Signed-off-by: Eric <menwe@amazon.com> * add/exposes types for datasources as a set of services Signed-off-by: Eric <menwe@amazon.com> * add datasource selector unit tests Signed-off-by: Eric <menwe@amazon.com> * add metadata to selectable Signed-off-by: Eric <menwe@amazon.com> * redirection to observability for non-index-pattern datasource Signed-off-by: Eric <menwe@amazon.com> * add datasource factory tests Signed-off-by: Eric <menwe@amazon.com> * add datasource service test Signed-off-by: Eric <menwe@amazon.com> * datasources related fixes Signed-off-by: Eric <menwe@amazon.com> * add tests for datasource selectable Signed-off-by: Eric <menwe@amazon.com> * added types/interfaces for sidebar selector, and add a couple of enhancements Signed-off-by: Eric <menwe@amazon.com> * remove pill effect Signed-off-by: Eric <menwe@amazon.com> * change type for name display in selector for index patterns Signed-off-by: Eric <menwe@amazon.com> * remove legacy index selector Signed-off-by: Eric <menwe@amazon.com> * rename datasource change handler Signed-off-by: Eric <menwe@amazon.com> * remove unused constants Signed-off-by: Eric <menwe@amazon.com> * fix a redirection bug Signed-off-by: Eric <menwe@amazon.com> * add to change log Signed-off-by: Eric <menwe@amazon.com> * fix bg color issue in source selector Signed-off-by: Eric <menwe@amazon.com> * address oui and missing guard Signed-off-by: Eric <menwe@amazon.com> * add test subj Signed-off-by: Eric <menwe@amazon.com> * i18 and datasource interface default return Signed-off-by: Eric <menwe@amazon.com> * add default datasource tests Signed-off-by: Eric <menwe@amazon.com> * fix typo Signed-off-by: Eric <menwe@amazon.com> * modify wording Signed-off-by: Eric <menwe@amazon.com> * add experimental annotation to datasource Signed-off-by: Eric <menwe@amazon.com> * add type datasource filtering to remove type error hint Signed-off-by: Eric <menwe@amazon.com> * remove unused type Signed-off-by: Eric <menwe@amazon.com> * add 'type' to option type Signed-off-by: Eric <menwe@amazon.com> * Type fixes Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * cherry-pick type changes from remote and add partial fixes Signed-off-by: Eric <menwe@amazon.com> * add one type exports Signed-off-by: Eric <menwe@amazon.com> * remaining type errors fixed Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * addressing comments Signed-off-by: Eric <menwe@amazon.com> * address dedup Signed-off-by: Eric <menwe@amazon.com> * refactor datasource_selectable to address comments Signed-off-by: Joshua Li <joshuali925@gmail.com> * remove unnecessary optional chaining Signed-off-by: Joshua Li <joshuali925@gmail.com> * refactor variable names Signed-off-by: Joshua Li <joshuali925@gmail.com> * move functnions out of selectable component Signed-off-by: Eric <menwe@amazon.com> * add comments for dedup/options list updates Signed-off-by: Eric <menwe@amazon.com> * add experimental annotation Signed-off-by: Eric <menwe@amazon.com> * callback and experimental annotation on types Signed-off-by: Eric <menwe@amazon.com> * handleSourceSelection callback Signed-off-by: Eric <menwe@amazon.com> * datasource annotation and import adjustment Signed-off-by: Eric <menwe@amazon.com> * remove pill effect Signed-off-by: Eric <menwe@amazon.com> * minor changes addressing latest comments Signed-off-by: Eric <menwe@amazon.com> * remove unused tests Signed-off-by: Eric <menwe@amazon.com> --------- Signed-off-by: Eric <menwe@amazon.com> Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> Signed-off-by: Joshua Li <joshuali925@gmail.com> Co-authored-by: Josh Romero <rmerqg@amazon.com> Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com> Co-authored-by: Joshua Li <joshuali925@gmail.com>

mengweieric added 22 commits September 21, 2023 20:46

initial commit for datasource

3758626

Signed-off-by: Eric <menwe@amazon.com>

initial commit for datasource service

3f6b467

Signed-off-by: Eric <menwe@amazon.com>

[Data Sources] Move datasource codebase from datasource plugin to dat…

634c074

…a plugin Signed-off-by: Eric <menwe@amazon.com>

[Data Sources] Add datasource factory

160c73e

Signed-off-by: Eric <menwe@amazon.com>

datasource service

12ab226

Signed-off-by: Eric <menwe@amazon.com>

datasource with factory

c71e0ea

Signed-off-by: Eric <menwe@amazon.com>

datasource selector

ad55a8a

Signed-off-by: Eric <menwe@amazon.com>

exposes datasources from data plugin

5ce2363

Signed-off-by: Eric <menwe@amazon.com>

index pattern datasource registration

0042959

Signed-off-by: Eric <menwe@amazon.com>

add datasource selector to discover

1b8a746

Signed-off-by: Eric <menwe@amazon.com>

remove unused files

23cf242

Signed-off-by: Eric <menwe@amazon.com>

add/exposes types for datasources as a set of services

23aba4a

Signed-off-by: Eric <menwe@amazon.com>

add datasource selector unit tests

249f139

Signed-off-by: Eric <menwe@amazon.com>

merge datasource selector features with main

116d1c1

Signed-off-by: Eric <menwe@amazon.com>

add metadata to selectable

2b8f7ff

Signed-off-by: Eric <menwe@amazon.com>

redirection to observability for non-index-pattern datasource

c8a29b7

Signed-off-by: Eric <menwe@amazon.com>

add datasource factory tests

b31e16f

Signed-off-by: Eric <menwe@amazon.com>

add datasource service test

4f1dc68

Signed-off-by: Eric <menwe@amazon.com>

datasources related fixes

6e8c2d1

Signed-off-by: Eric <menwe@amazon.com>

add tests for datasource selectable

e873130

Signed-off-by: Eric <menwe@amazon.com>

added types/interfaces for sidebar selector, and add a couple of enha…

b54dedd

…ncements Signed-off-by: Eric <menwe@amazon.com>

remove pill effect

94de201

Signed-off-by: Eric <menwe@amazon.com>

mengweieric requested review from ananzh, kavilla, seanneumann, AMoo-Miki, ashwin-pc, joshuarrrr, abbyhu2000 and zengyan-amazon as code owners October 2, 2023 03:14

mengweieric added 5 commits October 5, 2023 21:49

move functnions out of selectable component

ff8f3ef

Signed-off-by: Eric <menwe@amazon.com>

add comments for dedup/options list updates

0a1bfd5

Signed-off-by: Eric <menwe@amazon.com>

add experimental annotation

21af094

Signed-off-by: Eric <menwe@amazon.com>

callback and experimental annotation on types

24e6775

Signed-off-by: Eric <menwe@amazon.com>

handleSourceSelection callback

fe8cfeb

Signed-off-by: Eric <menwe@amazon.com>

ashwin-pc reviewed Oct 5, 2023

View reviewed changes

mengweieric added 2 commits October 5, 2023 23:49

datasource annotation and import adjustment

81ff866

Signed-off-by: Eric <menwe@amazon.com>

remove pill effect

30fc3d6

Signed-off-by: Eric <menwe@amazon.com>

ashwin-pc previously approved these changes Oct 5, 2023

View reviewed changes

minor changes addressing latest comments

5ab664b

Signed-off-by: Eric <menwe@amazon.com>

mengweieric dismissed ashwin-pc’s stale review via 5ab664b October 6, 2023 00:00

ashwin-pc previously approved these changes Oct 6, 2023

View reviewed changes

remove unused tests

bea8e75

Signed-off-by: Eric <menwe@amazon.com>

mengweieric dismissed ashwin-pc’s stale review via bea8e75 October 6, 2023 00:59

ashwin-pc approved these changes Oct 6, 2023

View reviewed changes

AMoo-Miki approved these changes Oct 6, 2023

View reviewed changes

ashwin-pc merged commit 1e980fa into opensearch-project:main Oct 6, 2023
54 of 55 checks passed

opensearch-trigger-bot bot mentioned this pull request Oct 6, 2023

[Backport 2.x] [Feature] Datasource selector of multiple datasources #5235

Merged

mengweieric deleted the feature/mul-data-source branch October 6, 2023 02:53

joshuarrrr added the backport 2.11 label Oct 6, 2023

opensearch-trigger-bot bot mentioned this pull request Oct 6, 2023

[Backport 2.11] [Feature] Datasource selector of multiple datasources #5236

Merged

bandinib-amzn mentioned this pull request Jan 19, 2024

[MD] Data source picker should have same behavior in devtool, tutorial, etc where it is used #5717

Closed

bandinib-amzn mentioned this pull request Feb 2, 2024

Add datasource picker to import saved object flyout when multiple data source is enabled #5781

Merged

7 tasks

BionIT mentioned this pull request Feb 2, 2024

Support multiple data source use case in existing data source selector #5790

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Feature] Datasource selector of multiple datasources #5167

[Feature] Datasource selector of multiple datasources #5167

mengweieric commented Oct 2, 2023 •

edited by joshuarrrr

Loading

ashwin-pc left a comment

ashwin-pc Oct 5, 2023

ashwin-pc Oct 5, 2023

	singleSelection = true,
	singleSelection = { asPlainText: true },

[Feature] Datasource selector of multiple datasources #5167

[Feature] Datasource selector of multiple datasources #5167

Conversation

mengweieric commented Oct 2, 2023 • edited by joshuarrrr Loading

Description

Issues Resolved

Screenshot

Testing the changes

Check List

ashwin-pc left a comment

Choose a reason for hiding this comment

ashwin-pc Oct 5, 2023

Choose a reason for hiding this comment

ashwin-pc Oct 5, 2023

Choose a reason for hiding this comment

mengweieric commented Oct 2, 2023 •

edited by joshuarrrr

Loading