Fix for checkForFunctionProperty so that order does not matter #6248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
cwperks
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
BSFishy,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT and
xinruiba
as code owners
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6248 +/- ##
==========================================
- Coverage 67.56% 67.47% -0.10%
==========================================
Files 3379 3368 -11
Lines 65894 65431 -463
Branches 10660 10560 -100
==========================================
- Hits 44522 44147 -375
+ Misses 18774 18713 -61
+ Partials 2598 2571 -27
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
seraphjiang
reviewed
Mar 22, 2024
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
tianleh
reviewed
Mar 23, 2024
Signed-off-by: Craig Perkins <cwperx@amazon.com>
tianleh
approved these changes
Mar 26, 2024
|
@ashwin-pc @joshuarrrr Could I get some reviews on this PR? |
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 9, 2024
* Fix for checkForFunctionProperty so that order does not matter Signed-off-by: Craig Perkins <cwperx@amazon.com> * Remove import for inspect Signed-off-by: Craig Perkins <cwperx@amazon.com> * Add to CHANGELOG Signed-off-by: Craig Perkins <cwperx@amazon.com> * replace with jest.fn() Signed-off-by: Craig Perkins <cwperx@amazon.com> * Update CHANGELOG Signed-off-by: Craig Perkins <cwperx@amazon.com> * Add scenarios where object does not contain fn Signed-off-by: Craig Perkins <cwperx@amazon.com> --------- Signed-off-by: Craig Perkins <cwperx@amazon.com> Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Co-authored-by: SuZhou-Joe <suzhou@amazon.com> Co-authored-by: ZilongX <99905560+ZilongX@users.noreply.github.com> (cherry picked from commit b70c327) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
seraphjiang
reviewed
Apr 10, 2024
Comment on lines
+82
to
+89
| for (const value of Object.values(object)) { | ||
| if (typeof value === 'function') { | ||
| return true; | ||
| } else if (Utils.isObject(value) && Utils.checkForFunctionProperty(value)) { | ||
| return true; | ||
| } | ||
| } | ||
| return false; |
There was a problem hiding this comment.
@cwperks could we refactory code a little
for (const value of Object.values(object)) {
if (typeof value === 'function') return true;
if (Utils.isObject(value) && Utils.checkForFunctionProperty(value)) return true;
}
return false;
ananzh
pushed a commit
that referenced
this pull request
Apr 12, 2024
#6384) * Fix for checkForFunctionProperty so that order does not matter * Remove import for inspect * replace with jest.fn() * Add scenarios where object does not contain fn --------- Signed-off-by: Craig Perkins <cwperx@amazon.com> Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Co-authored-by: SuZhou-Joe <suzhou@amazon.com> Co-authored-by: ZilongX <99905560+ZilongX@users.noreply.github.com> (cherry picked from commit b70c327) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue with the implementation of a utility function used in vis_type_vega plugin where order matters when determining if an object has a property that is a function. This PR adds test to assert the desired behavior in multiple scenarios.
Check List
yarn test:jestyarn test:jest_integration