[Multiple Datasource] Allow top nav menu to mount data source menu for use case when both menus are mounted #6268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lu Yu <nluyu@amazon.com>
BionIT
added
backport 2.x
multiple datasource
BionIT
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
BSFishy,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl and
xinruiba
as code owners
Signed-off-by: Lu Yu <nluyu@amazon.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6268 +/- ##
==========================================
+ Coverage 67.42% 67.44% +0.02%
==========================================
Files 3362 3362
Lines 65258 65261 +3
Branches 10524 10526 +2
==========================================
+ Hits 43999 44017 +18
+ Misses 18701 18688 -13
+ Partials 2558 2556 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| @@ -97,10 +110,12 @@ export function TopNavMenu(props: TopNavMenuProps): ReactElement | null { | |||
| } | |||
|
|
|||
| function renderMenu(className: string): ReactElement | null { | |||
| if (!config || config.length === 0) return null; | |||
| if ((!config || config.length === 0) && (!showDataSourceMenu || !dataSourceMenuConfig)) | |||
There was a problem hiding this comment.
There is typo in this file with line#124 // Validate presense of all required fields, presense should be presence
There was a problem hiding this comment.
Yeah, fixed the comment
Flyingliuhub
previously approved these changes
Mar 26, 2024
Signed-off-by: Lu Yu <nluyu@amazon.com>
Signed-off-by: Lu Yu <nluyu@amazon.com>
Signed-off-by: Lu Yu <nluyu@amazon.com>
ZilongX
approved these changes
Mar 26, 2024
Flyingliuhub
approved these changes
Mar 26, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 26, 2024
…r use case when both menus are mounted (#6268) * allow top nav menu to mount data source menu Signed-off-by: Lu Yu <nluyu@amazon.com> * add change log Signed-off-by: Lu Yu <nluyu@amazon.com> * update snapshots Signed-off-by: Lu Yu <nluyu@amazon.com> * update snapshot Signed-off-by: Lu Yu <nluyu@amazon.com> --------- Signed-off-by: Lu Yu <nluyu@amazon.com> (cherry picked from commit e84582c) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
BionIT
pushed a commit
that referenced
this pull request
Mar 29, 2024
…r use case when both menus are mounted (#6268) (#6273) * allow top nav menu to mount data source menu Signed-off-by: Lu Yu <nluyu@amazon.com> * add change log Signed-off-by: Lu Yu <nluyu@amazon.com> * update snapshots Signed-off-by: Lu Yu <nluyu@amazon.com> * update snapshot Signed-off-by: Lu Yu <nluyu@amazon.com> --------- Signed-off-by: Lu Yu <nluyu@amazon.com> (cherry picked from commit e84582c) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
77 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change allows top nav menu to mount data source menu for use case when both menus are mounted.
Issues Resolved
Fixes #6229
Screenshot
topnavmenu.mp4
Testing the changes
The following steps were performed in the recording above:
Check List
yarn test:jestyarn test:jest_integration