Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update locales.js for support pl language #6284

Closed
wants to merge 5 commits into from

Conversation

fcientymeh
Copy link

@fcientymeh fcientymeh commented Mar 28, 2024

Needed for translating FormatMessage format to pl language

Description

Issues Resolved

Screenshot

Testing the changes

Check List

  • [x ] All tests pass
    • yarn test:jest
    • [] yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Needed for translating FormatMessage format

Signed-off-by: Andrzej M. <122584230+fcientymeh@users.noreply.github.com>
@fcientymeh
Copy link
Author

Can anyone help me with pull request, and DCO problem?
I have send this first pull request, but there is some problem with github/DCO:
image

My name in profile was Andrzej M., but during commit with adding Signed-off-by..., the dot(.) on the end of username was removed.
So, my name, and Signed-off in commit were not the same (see screen above).

Is this is a bug in github?
If the dot (.) is not permitted in username, it shoud be checked during creating/editing profile maybe...

@fcientymeh fcientymeh closed this Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant