[MDS] Update Data source selector behavior for defaultOption

[huyaboo]

Description

Previously, DataSourceSelector did not respect the Placeholder text. This PR will modify the behavior of defaultOption to be more consistent

TODO:

• Will resolve merge conflicts with [Multiple DataSource] DataSourceSelectable support to render label by getting it from dataSourceOptions #6358
• One snapshot test will fail on DataSourceSelectable. This will be addressed when [Multiple DataSource] DataSourceSelectable support to render label by getting it from dataSourceOptions #6358 is merged

Issues Resolved

Partially addresses #6274

Screenshot

Testing the changes

The following are the test scenarios:

• if defaultOption = undefined;:

  • Show defaultDataSource:
  • 
  • Show Local Cluster if hideLocalCluster is disabled and defaultDataSource is filtered out:
  • 
  • Show first datasource in list if Local Cluster is hidden and defaultDataSource is filtered out:
  • 
  • Show toast when nothing is left:
  • 

• if defaultOption = []:

  • Show placeholder text:
  • 

• if defaultOption = [{id}]:

  • If id = undefined throw toast:
  • 
  • If id = Source B and Source B is not filtered out, show selected option:
  • 
  • If id = Source B and Source B is filtered out, show toast:
  • 
  • If id = invalid-id, show toast:
  • 

Check List

• All tests pass
  • yarn test:jest
  • yarn test:jest_integration
• New functionality includes testing.
• New functionality has been documented.
• Update CHANGELOG.md
• Commits are signed per the DCO using --signoff

[zhyuanqi]

Should we also use the callback function to tell plugins team that Invalid state?

[huyaboo]

So this function, regardless of valid/invalid id, will set the new state and call the callback function. If the id is valid, we change the selectedOption to be whatever was set in props and call the callback function with this. IF the id is invalid, we change the selectedOption to be [] and return the callback function with []. The only thing that changes is whether to add a toast message.

[zhyuanqi]

GOt it.

[zhyuanqi]

What if plugins team pass in local cluster?

[huyaboo]

Local Cluster should already be in the dataSources because we check if the hideLocalCluster is disabled and add the local cluster before calling this method. In this case, the id = '' and because Local Cluster is in the list of datasources, dataSources.find((ds) => ds.id === id) should return the Local Cluster

[zhyuanqi]

Make sense!

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 32.63%. Comparing base (85df662) to head (6d7a49a).
Report is 3 commits behind head on main.

❗ Current head 6d7a49a differs from pull request most recent head 456209a. Consider uploading reports for the commit 456209a to get more accurate results

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #6372       +/-   ##
===========================================
- Coverage   55.58%   32.63%   -22.96%     
===========================================
  Files        1199     2249     +1050     
  Lines       24259    45490    +21231     
  Branches     4087     7127     +3040     
===========================================
+ Hits        13485    14844     +1359     
- Misses      10133    29951    +19818     
- Partials      641      695       +54     

Flag	Coverage Δ
Linux_1	32.63% <ø> (?)
Windows_2	?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[zhyuanqi]

Hi Huy. Could you check the code cov. It shows failed on my side

[BionIT]

We probably should start extracting the error handling messages out so that we can keep the message consistent across all data source component

[zhongnansu]

lgtm, can you resolve the conflict of changelog.md

[seraphjiang]

Thanks @huyaboo @zhyuanqi @BionIT @zhongnansu to keep enhance the experience for MDS