Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate data source attribute interface #6437

Merged
merged 1 commit into from
Apr 15, 2024
Merged

Remove duplicate data source attribute interface #6437

merged 1 commit into from
Apr 15, 2024

Conversation

bandinib-amzn
Copy link
Member

@bandinib-amzn bandinib-amzn commented Apr 12, 2024 •
edited

Description

Removed duplicate data source attribute interface from data source management plugin.

Issues Resolved

Partially resolves #6204

Screenshot

Screen.Recording.2024-04-15.at.11.35.49.AM.mov

Above recording performs following steps and verify this changes doesn't introduce regressions.

  • Create data source with Username & Password authentication type.
  • Verify Test connection works while creating data source.
  • Go to View/Edit data source screen.
  • Verify Test connection still works.
  • Change title of data source and save. Data source management page reflects modified changes.
  • Using dev tool, verify all the attributes of data source including data source version, installed plugin list etc are saved in system index (Dashboards meta storage).

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@codecov Codecov
Copy link

codecov bot commented Apr 13, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.20%. Comparing base (85df662) to head (0ebafb9).
Report is 14 commits behind head on main.

❗ Current head 0ebafb9 differs from pull request most recent head 7a061d9. Consider uploading reports for the commit 7a061d9 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6437      +/-   ##
==========================================
- Coverage   55.58%   52.20%   -3.39%     
==========================================
  Files        1199     2561    +1362     
  Lines       24259    50002   +25743     
  Branches     4087     7830    +3743     
==========================================
+ Hits        13485    26103   +12618     
- Misses      10133    22658   +12525     
- Partials      641     1241     +600
Flag Coverage Δ
Linux_1 32.72% <ø> (?)
Windows_2 55.58% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seraphjiang seraphjiang added the multiple datasource multiple datasource project label Apr 13, 2024
@bandinib-amzn bandinib-amzn force-pushed the refactor-data-source-attributes branch from 0ebafb9 to 3181a1f Compare April 15, 2024 18:17
@bandinib-amzn bandinib-amzn marked this pull request as ready for review April 15, 2024 18:18
@bandinib-amzn
Remove duplicate data source attribute interface
7a061d9 
Signed-off-by: Bandini Bhopi <bandinib@amazon.com>
@bandinib-amzn bandinib-amzn force-pushed the refactor-data-source-attributes branch from 3181a1f to 7a061d9 Compare April 15, 2024 18:24
@bandinib-amzn bandinib-amzn mentioned this pull request Apr 15, 2024
Closed
3 tasks
yujin-emma
yujin-emma approved these changes Apr 15, 2024
View reviewed changes
Copy link
Contributor

@yujin-emma yujin-emma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this improvement

ZilongX
ZilongX reviewed Apr 15, 2024
View reviewed changes
src/plugins/data_source_management/public/types.ts
title: string;
description?: string;
endpoint?: string;
dataSourceVersion?: string;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may break the datasource metadata fetch flow, need to double check.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually tested. I have attached video in detail. .kibana index has data source version, installed plugin version information.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know if more testing required.

@ZilongX ZilongX self-requested a review April 15, 2024 19:34
@ZilongX ZilongX merged commit e785fd3 into opensearch-project:main Apr 15, 2024
74 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 15, 2024
@github-actions
Remove duplicate data source attribute interface (#6437)
61653ff 
Signed-off-by: Bandini Bhopi <bandinib@amazon.com>
(cherry picked from commit e785fd3)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Apr 15, 2024
Merged
@bandinib-amzn bandinib-amzn deleted the refactor-data-source-attributes branch April 15, 2024 19:38
bandinib-amzn pushed a commit that referenced this pull request Apr 15, 2024
@github-actions @bandinib-amzn
Remove duplicate data source attribute interface (#6437)
9ea06c3 
Signed-off-by: Bandini Bhopi <bandinib@amazon.com>
(cherry picked from commit e785fd3)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
ZilongX pushed a commit that referenced this pull request Apr 15, 2024
@opensearch-trigger-bot @github-actions
Remove duplicate data source attribute interface (#6437) (#6462)
7f8586f 
Signed-off-by: Bandini Bhopi <bandinib@amazon.com>
(cherry picked from commit e785fd3)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@BionIT BionIT mentioned this pull request Apr 22, 2024
Closed
77 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZilongX ZilongX ZilongX approved these changes

@yujin-emma yujin-emma yujin-emma approved these changes

@xinruiba xinruiba xinruiba approved these changes

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq is a code owner

@SuZhou-Joe SuZhou-Joe Awaiting requested review from SuZhou-Joe SuZhou-Joe is a code owner

@ruanyl ruanyl Awaiting requested review from ruanyl ruanyl is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT is a code owner

Assignees

@bandinib-amzn bandinib-amzn

Labels
backport 2.x multiple datasource multiple datasource project seasoned-contributor v2.14.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Multi data Source] Data source and Data source management plugin auditing
5 participants
@bandinib-amzn @ZilongX @yujin-emma @xinruiba @seraphjiang