[MD] Validate length of title to be no longer than 32 characters #6452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhongnansu
force-pushed
the
limit-title-length-in-create
branch
from
2868999
to
1c50e72
Compare
zhongnansu
changed the title
zhongnansu
force-pushed
the
limit-title-length-in-create
branch
2 times, most recently
from
859d2b9
to
6b051f8
Compare
zhongnansu
changed the title
zhongnansu
changed the title
zhongnansu
force-pushed
the
limit-title-length-in-create
branch
from
6b051f8
to
8f75470
Compare
zhongnansu
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT and
xinruiba
as code owners
zhongnansu
added
backport 2.x
multiple datasource
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6452 +/- ##
===========================================
+ Coverage 49.55% 62.51% +12.95%
===========================================
Files 2670 2976 +306
Lines 54290 58663 +4373
Branches 8878 9553 +675
===========================================
+ Hits 26906 36672 +9766
+ Misses 25720 19891 -5829
- Partials 1664 2100 +436
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
yujin-emma
reviewed
Apr 15, 2024
src/plugins/data_source_management/public/components/validation/datasource_form_validation.ts
Outdated
Show resolved
Hide resolved
zhyuanqi
approved these changes
Apr 15, 2024
BionIT
reviewed
Apr 15, 2024
zhongnansu
force-pushed
the
limit-title-length-in-create
branch
3 times, most recently
from
650c8e3
to
043f98c
Compare
BionIT
approved these changes
Apr 16, 2024
tianleh
reviewed
Apr 16, 2024
| @@ -50,8 +50,14 @@ export const isTitleValid = ( | |||
| error: '', | |||
| }; | |||
| /* Title validation */ | |||
| if (!title?.trim?.().length) { | |||
| if (!title.trim().length) { | |||
There was a problem hiding this comment.
Just curious whether title could be undefined. If yes, then calling trim function will throw exception. If no, then there is no concern.
There was a problem hiding this comment.
title will not be undefined, it's initialized with empty string
that's why in the function param, we didn't declare it to be optional param
Signed-off-by: Zhongnan Su <szhongna@amazon.com>
zhongnansu
force-pushed
the
limit-title-length-in-create
branch
from
043f98c
to
64ea71a
Compare
ZilongX
approved these changes
Apr 16, 2024
Closed
36 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add validation for length of title to be no longer than 32 characters in create flow. Otherwise show inline error message, and disable the buttons. This applies to both create flow and edit flow
Issues Resolved
#6433
#6432
Screenshot
iShot_2024-04-14_23.51.32.mp4
Testing the changes
Check List
yarn test:jestyarn test:jest_integration