Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For selectable component, remove group label and close popover after selection #6515

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

zhyuanqi
Copy link
Collaborator

@zhyuanqi zhyuanqi commented Apr 17, 2024

For selectable component, remove group label and close popover after selection

Issues Resolved

  • Remove group label
  • Close popover after selection

Screenshot

Screenshot 2024-04-17 at 1 25 57 PM
Screen.Recording.2024-04-17.at.1.16.25.PM.mov

Testing the changes

See videos for testing

Changelog

  • skip

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@zhyuanqi zhyuanqi changed the title For selectable component, remove group label and close popover after … For selectable component, remove group label and close popover after selection Apr 17, 2024
Copy link
Contributor

ℹ️ Manual Changeset Creation Reminder

Please ensure manual commit for changeset file 6515.yml under folder changelogs/fragments to complete this PR.

If you want to use the available OpenSearch Changeset Bot App to avoid manual creation of changeset file you can install it in your forked repository following this link.

For more information about formatting of changeset files, please visit OpenSearch Auto Changeset and Release Notes Tool.

Copy link
Contributor

❌ Changeset File Not Added Yet

Please ensure manual commit for changeset file 6515.yml under folder changelogs/fragments to complete this PR. File still missing.

1 similar comment
Copy link
Contributor

❌ Changeset File Not Added Yet

Please ensure manual commit for changeset file 6515.yml under folder changelogs/fragments to complete this PR. File still missing.

@zhyuanqi zhyuanqi force-pushed the selectable-ui branch 2 times, most recently from 06885c8 to 6888f78 Compare April 17, 2024 20:24
Copy link
Contributor

❌ Changeset File Not Added Yet

Please ensure manual commit for changeset file 6515.yml under folder changelogs/fragments to complete this PR. File still missing.

BionIT
BionIT previously approved these changes Apr 17, 2024
zhongnansu
zhongnansu previously approved these changes Apr 17, 2024
@github-actions github-actions bot added Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry and removed failed changeset labels Apr 17, 2024
@zhyuanqi zhyuanqi dismissed stale reviews from zhongnansu and BionIT via bf7cbd7 April 17, 2024 20:55
Copy link
Contributor

❌ Invalid Prefix For Manual Changeset Creation

Invalid description prefix. Found "feat". Only "skip" entry option is permitted for manual commit of changeset files.

If you were trying to skip the changelog entry, please use the "skip" entry option in the ##Changelog section of your PR description.

@github-actions github-actions bot added failed changeset and removed Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry labels Apr 17, 2024
…selection

Signed-off-by: Yuanqi(Ella) Zhu <zhyuanqi@amazon.com>
Copy link
Contributor

❌ Invalid Prefix For Manual Changeset Creation

Invalid description prefix. Found "feat". Only "skip" entry option is permitted for manual commit of changeset files.

If you were trying to skip the changelog entry, please use the "skip" entry option in the ##Changelog section of your PR description.

@github-actions github-actions bot added Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry and removed failed changeset labels Apr 17, 2024
Copy link

codecov bot commented Apr 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.63%. Comparing base (d2d410b) to head (7068a04).
Report is 4 commits behind head on main.

❗ Current head 7068a04 differs from pull request most recent head 523daa0. Consider uploading reports for the commit 523daa0 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #6515       +/-   ##
===========================================
+ Coverage   32.93%   55.63%   +22.70%     
===========================================
  Files        2260     1201     -1059     
  Lines       45769    24289    -21480     
  Branches     7200     4098     -3102     
===========================================
- Hits        15075    13514     -1561     
+ Misses      29984    10129    -19855     
+ Partials      710      646       -64     
Flag Coverage Δ
Linux_1 ?
Linux_2 55.63% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Flyingliuhub Flyingliuhub merged commit 0b90e9b into opensearch-project:main Apr 17, 2024
66 of 67 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-6515-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 0b90e9bac2ee646d7e922fc5f64ccc0d2ca11861
# Push it to GitHub
git push --set-upstream origin backport/backport-6515-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-6515-to-2.x.

opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 18, 2024
…selection (#6515)

Signed-off-by: Yuanqi(Ella) Zhu <zhyuanqi@amazon.com>
(cherry picked from commit 0b90e9b)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
ZilongX pushed a commit that referenced this pull request Apr 18, 2024
…selection (#6515) (#6536)

Signed-off-by: Yuanqi(Ella) Zhu <zhyuanqi@amazon.com>
(cherry picked from commit 0b90e9b)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x multiple datasource multiple datasource project Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry v2.14.0 valued-contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants