[BUG] Fix permission check failed with empty workspace for find method #6527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hailong Cui <ihailong@amazon.com>
Hailong-am
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT and
xinruiba
as code owners
ℹ️ Manual Changeset Creation ReminderPlease ensure manual commit for changeset file 6527.yml under folder changelogs/fragments to complete this PR. If you want to use the available OpenSearch Changeset Bot App to avoid manual creation of changeset file you can install it in your forked repository following this link. For more information about formatting of changeset files, please visit OpenSearch Auto Changeset and Release Notes Tool. |
❌ Changeset File Not Added YetPlease ensure manual commit for changeset file 6527.yml under folder changelogs/fragments to complete this PR. File still missing. |
SuZhou-Joe
previously approved these changes
Apr 18, 2024
wanglam
reviewed
Apr 18, 2024
src/plugins/workspace/server/saved_objects/workspace_saved_objects_client_wrapper.ts
Show resolved
Hide resolved
Signed-off-by: Hailong Cui <ihailong@amazon.com>
wanglam
reviewed
Apr 18, 2024
src/plugins/workspace/server/saved_objects/workspace_saved_objects_client_wrapper.test.ts
Show resolved
Hide resolved
Signed-off-by: Hailong Cui <ihailong@amazon.com>
SuZhou-Joe
approved these changes
Apr 19, 2024
wanglam
approved these changes
Apr 19, 2024
ruanyl
approved these changes
Apr 19, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 23, 2024
#6527) * Fix permission check failed with empty workspace for find method Signed-off-by: Hailong Cui <ihailong@amazon.com> * Changeset file for PR #6527 created/updated * Add unit test case Signed-off-by: Hailong Cui <ihailong@amazon.com> * address review comments Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 432afc7) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe
pushed a commit
that referenced
this pull request
Apr 23, 2024
#6527) (#6608) * Fix permission check failed with empty workspace for find method * Changeset file for PR #6527 created/updated * Add unit test case * address review comments --------- (cherry picked from commit 432afc7) Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
LDrago27
pushed a commit
to LDrago27/OpenSearch-Dashboards
that referenced
this pull request
Jun 3, 2024
opensearch-project#6527) * Fix permission check failed with empty workspace for find method Signed-off-by: Hailong Cui <ihailong@amazon.com> * Changeset file for PR opensearch-project#6527 created/updated * Add unit test case Signed-off-by: Hailong Cui <ihailong@amazon.com> * address review comments Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
when doing permission check, it will filter workspace list and verify there at least have 1 workspace user have permission, otherwise it will throw exception.
The bug is that, if we pass an empty array, that will go through this check and throw exception.
Issues Resolved
#6528
Screenshot
Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integration