Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Multiple Datasource]update no data source text font and button size #6549

Merged
merged 2 commits into from
Apr 19, 2024

Conversation

yujin-emma
Copy link
Contributor

@yujin-emma yujin-emma commented Apr 19, 2024

Description

  1. Change the text font to small
  2. Change the footer button to small

Issues Resolved

#6548

Screenshot

Screenshot 2024-04-18 at 17 09 17

Testing the changes

Changelog

  • skip

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>
Copy link
Contributor

ℹ️ Manual Changeset Creation Reminder

Please ensure manual commit for changeset file 6549.yml under folder changelogs/fragments to complete this PR.

If you want to use the available OpenSearch Changeset Bot App to avoid manual creation of changeset file you can install it in your forked repository following this link.

For more information about formatting of changeset files, please visit OpenSearch Auto Changeset and Release Notes Tool.

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>
Copy link

codecov bot commented Apr 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.00%. Comparing base (d2d410b) to head (75911d4).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6549      +/-   ##
==========================================
+ Coverage   32.93%   33.00%   +0.06%     
==========================================
  Files        2260     2262       +2     
  Lines       45769    45824      +55     
  Branches     7200     7213      +13     
==========================================
+ Hits        15075    15122      +47     
- Misses      29984    29989       +5     
- Partials      710      713       +3     
Flag Coverage Δ
Linux_1 ?
Windows_1 33.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yujin-emma yujin-emma marked this pull request as ready for review April 19, 2024 01:26
@github-actions github-actions bot added the Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry label Apr 19, 2024
@BionIT BionIT merged commit bbde563 into opensearch-project:main Apr 19, 2024
68 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 19, 2024
…6549)

* update no data source text font and button size

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* update change log and snapshot

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

---------

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>
(cherry picked from commit bbde563)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
BionIT added a commit that referenced this pull request Apr 19, 2024
…6549) (#6551)

* update no data source text font and button size

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* update change log and snapshot

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

---------

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>
(cherry picked from commit bbde563)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Lu Yu <nluyu@amazon.com>
LDrago27 pushed a commit to LDrago27/OpenSearch-Dashboards that referenced this pull request Jun 3, 2024
…pensearch-project#6549)

* update no data source text font and button size

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* update change log and snapshot

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

---------

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>
@yujin-emma yujin-emma deleted the new-popover branch June 12, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry v2.14.0 valued-contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants