[Draft][OE] Adds TS check workflow #6586
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
ashwin-pc
requested review from
ananzh,
kavilla,
AMoo-Miki,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT and
xinruiba
as code owners
github-actions
bot
added
distinguished-contributor
Skip-Changelog
Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
SuZhou-Joe
reviewed
Apr 24, 2024
| uses: umani/changed-files@v4.0.0 | ||
| with: | ||
| repo-token: ${{ github.token }} | ||
| pattern: '^.*\.ts$' |
There was a problem hiding this comment.
Suggested change
| pattern: '^.*\.ts$' | |
| pattern: '^.*\.tsx?$' |
I guess tsx should be included as well
ruanyl
reviewed
Apr 25, 2024
| include: '["\\.ts$"]' | ||
| - name: Detecting files changed | ||
| id: files | ||
| uses: umani/changed-files@v4.0.0 |
There was a problem hiding this comment.
Would you consider https://github.com/tj-actions/changed-files which is more actively maintained?
|
@SuZhou-Joe @ruanyl , thanks for reviewing this. This PR isnt ready for review yet, but i cant put it in draft cause the CI wont run if it is, and i need it to test the github workflow. Will let you know once this is ready :) |
ashwin-pc
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a TS check to the github workflow. This causes increases in TS Errors to be flagged and fail the CI
Issues Resolved
Screenshot
Testing the changes
The Typescript Check in the PR's CI should pass
Changelog
Check List
yarn test:jestyarn test:jest_integration