Fix datasource conntection failure #6648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuanqi(Ella) Zhu <zhyuanqi@amazon.com>
zhyuanqi
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT and
xinruiba
as code owners
BionIT
approved these changes
Apr 26, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6648 +/- ##
==========================================
- Coverage 67.79% 67.74% -0.06%
==========================================
Files 3413 3413
Lines 66755 66755
Branches 10861 10861
==========================================
- Hits 45256 45221 -35
- Misses 18856 18885 +29
- Partials 2643 2649 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
zhongnansu
approved these changes
Apr 26, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 26, 2024
* Fix datasource conntection failure Signed-off-by: Yuanqi(Ella) Zhu <zhyuanqi@amazon.com> * Changeset file for PR #6648 created/updated --------- Signed-off-by: Yuanqi(Ella) Zhu <zhyuanqi@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit b29d90e) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
zhongnansu
pushed a commit
that referenced
this pull request
Apr 26, 2024
* Fix datasource conntection failure Signed-off-by: Yuanqi(Ella) Zhu <zhyuanqi@amazon.com> * Changeset file for PR #6648 created/updated --------- Signed-off-by: Yuanqi(Ella) Zhu <zhyuanqi@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit b29d90e) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-6648-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b29d90e8277b878b1d534ce22cb6c03170f18746
# Push it to GitHub
git push --set-upstream origin backport/backport-6648-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.xThen, create a pull request where the |
|
@zhyuanqi auto backport failed to 2.x and we'll need a manual backport for this one |
|
thanks @zhongnansu for taking care of the backport ! |
zhongnansu
pushed a commit
to zhongnansu/OpenSearch-Dashboards
that referenced
this pull request
Apr 26, 2024
* Fix datasource conntection failure Signed-off-by: Yuanqi(Ella) Zhu <zhyuanqi@amazon.com> * Changeset file for PR opensearch-project#6648 created/updated --------- Signed-off-by: Yuanqi(Ella) Zhu <zhyuanqi@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit b29d90e)
7 tasks
BionIT
pushed a commit
that referenced
this pull request
Apr 26, 2024
* Fix datasource conntection failure Signed-off-by: Yuanqi(Ella) Zhu <zhyuanqi@amazon.com> * Changeset file for PR #6648 created/updated --------- Signed-off-by: Yuanqi(Ella) Zhu <zhyuanqi@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit b29d90e) Co-authored-by: Yuanqi(Ella) Zhu <53279298+zhyuanqi@users.noreply.github.com>
LDrago27
pushed a commit
to LDrago27/OpenSearch-Dashboards
that referenced
this pull request
Jun 3, 2024
* Fix datasource conntection failure Signed-off-by: Yuanqi(Ella) Zhu <zhyuanqi@amazon.com> * Changeset file for PR opensearch-project#6648 created/updated --------- Signed-off-by: Yuanqi(Ella) Zhu <zhyuanqi@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix datasource conntection failure introduced by 0c114ce#diff-a01a6007a1a466a29810fbf0689bc607c3c3dfc9d3f7713da9bbf653beb92ef8R176
Screenshot
Changelog
Check List
yarn test:jestyarn test:jest_integration