-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MDS] Fix the dsm plugin setup when mds feature flag is disabled #7163
[MDS] Fix the dsm plugin setup when mds feature flag is disabled #7163
Conversation
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7163 +/- ##
==========================================
+ Coverage 67.48% 67.51% +0.02%
==========================================
Files 3468 3468
Lines 68375 68375
Branches 11114 11113 -1
==========================================
+ Hits 46146 46162 +16
+ Misses 19529 19516 -13
+ Partials 2700 2697 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Ryan Liang <jiallian@amazon.com>
a9ec9c1
to
c58b513
Compare
Description
Fix the dsm plugin setup when mds feature flag is disabled
Issues Resolved
#7143 introduced the behavior that Data source management plugin will always be registered, and this PR introduced the proper handling of DSM plugin setup when
data_source.enabled
is set to false.Changelog
Check List
yarn test:jest
yarn test:jest_integration