Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MDS] Fix the dsm plugin setup when mds feature flag is disabled #7163

Merged

Conversation

RyanL1997
Copy link
Contributor

@RyanL1997 RyanL1997 commented Jul 2, 2024

Description

Fix the dsm plugin setup when mds feature flag is disabled

Issues Resolved

#7143 introduced the behavior that Data source management plugin will always be registered, and this PR introduced the proper handling of DSM plugin setup when data_source.enabled is set to false.

Changelog

  • fix: [MDS] Fix the dsm plugin setup when mds feature flag is disabled

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link
Contributor

github-actions bot commented Jul 2, 2024

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

opensearch-changeset-bot bot added a commit to RyanL1997/OpenSearch-Dashboards that referenced this pull request Jul 2, 2024
Copy link

codecov bot commented Jul 2, 2024

Codecov Report

Attention: Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.

Project coverage is 67.51%. Comparing base (daccab7) to head (c58b513).
Report is 1 commits behind head on main.

Files Patch % Lines
...rc/plugins/data_source_management/public/plugin.ts 72.72% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7163      +/-   ##
==========================================
+ Coverage   67.48%   67.51%   +0.02%     
==========================================
  Files        3468     3468              
  Lines       68375    68375              
  Branches    11114    11113       -1     
==========================================
+ Hits        46146    46162      +16     
+ Misses      19529    19516      -13     
+ Partials     2700     2697       -3     
Flag Coverage Δ
Linux_1 33.05% <ø> (ø)
Linux_2 55.19% <ø> (ø)
Linux_3 45.35% <72.72%> (+0.01%) ⬆️
Linux_4 34.76% <0.00%> (ø)
Windows_1 33.09% <ø> (+0.02%) ⬆️
Windows_2 55.14% <ø> (ø)
Windows_3 45.37% <72.72%> (+0.01%) ⬆️
Windows_4 34.76% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mengweieric mengweieric merged commit 0cc2b99 into opensearch-project:main Jul 3, 2024
67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] data_source.enabled: false causes getDataSourceMenu to fail
3 participants