Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] [Navigation-next] Enrich breadcrumbs by workspace and use case #7392

Merged
merged 1 commit into from
Jul 23, 2024
Merged

[Backport 2.x] [Navigation-next] Enrich breadcrumbs by workspace and use case #7392

merged 1 commit into from
Jul 23, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 7ff8544 from #7360.

@github-actions @opensearch-changeset-bot
[Navigation-next] Enrich breadcrumbs by workspace and use case (#7360)
8274c66 
* breadcrumbs for workspace

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* add unit test

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* Changeset file for PR #7360 created/updated

* add unit test

Signed-off-by: Hailong Cui <ihailong@amazon.com>

---------

Signed-off-by: Hailong Cui <ihailong@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 7ff8544)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot added autocut Skip the changelog verification check on backports seasoned-contributor v2.16.0 navigation labels Jul 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

@codecov Codecov
Copy link

codecov bot commented Jul 23, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 80.30303% with 13 lines in your changes missing coverage. Please review.

Project coverage is 67.85%. Comparing base (1f5f461) to head (8274c66).
Report is 1 commits behind head on 2.x.

Files Patch % Lines
src/plugins/workspace/public/utils.ts 72.00% 5 Missing and 2 partials ⚠️
.../core/public/chrome/nav_group/nav_group_service.ts 86.20% 3 Missing and 1 partial ⚠️
src/core/public/chrome/chrome_service.tsx 50.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##              2.x    #7392      +/-   ##
==========================================
+ Coverage   67.83%   67.85%   +0.01%     
==========================================
  Files        3520     3520              
  Lines       69772    69824      +52     
  Branches    11375    11387      +12     
==========================================
+ Hits        47331    47377      +46     
- Misses      19652    19657       +5     
- Partials     2789     2790       +1
Flag Coverage Δ
Linux_1 33.17% <28.78%> (+<0.01%) ⬆️
Linux_2 55.66% <85.00%> (+0.04%) ⬆️
Linux_3 43.24% <0.00%> (-0.04%) ⬇️
Linux_4 34.93% <0.00%> (-0.03%) ⬇️
Windows_1 33.19% <28.78%> (+<0.01%) ⬆️
Windows_2 55.61% <85.00%> (+0.04%) ⬆️
Windows_3 43.25% <0.00%> (-0.04%) ⬇️
Windows_4 34.93% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ruanyl ruanyl merged commit 848459d into 2.x Jul 23, 2024
68 of 70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruanyl ruanyl ruanyl approved these changes

@SuZhou-Joe SuZhou-Joe SuZhou-Joe approved these changes

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba is a code owner

@zhyuanqi zhyuanqi Awaiting requested review from zhyuanqi zhyuanqi is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@LDrago27 LDrago27 Awaiting requested review from LDrago27 LDrago27 is a code owner

@virajsanghvi virajsanghvi Awaiting requested review from virajsanghvi virajsanghvi is a code owner

Assignees
No one assigned
Labels
autocut Skip the changelog verification check on backports failed changeset navigation seasoned-contributor v2.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ruanyl @SuZhou-Joe