Created a failing test to reproduce painless bug

Signed-off-by: Shivansh Arora <shivansh.arora@protonmail.com>
opensearch-project · Jun 28, 2023 · 4c711f0 · 4c711f0
1 parent 03bc192
commit 4c711f0
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 0 deletions.
diff --git a/...les/lang-painless/src/main/java/org/opensearch/painless/action/PainlessExecuteAction.java b/...les/lang-painless/src/main/java/org/opensearch/painless/action/PainlessExecuteAction.java
@@ -90,6 +90,7 @@
 import org.opensearch.script.ScriptContext;
 import org.opensearch.script.ScriptService;
 import org.opensearch.script.ScriptType;
+import org.opensearch.script.UpdateScript;
 import org.opensearch.threadpool.ThreadPool;
 import org.opensearch.transport.TransportService;
 
@@ -138,6 +139,7 @@ public static class Request extends SingleShardRequest<Request> implements ToXCo
             supportedContexts.put("painless_test", PainlessTestScript.CONTEXT);
             supportedContexts.put("filter", FilterScript.CONTEXT);
             supportedContexts.put("score", ScoreScript.CONTEXT);
+            supportedContexts.put("update", UpdateScript.CONTEXT);
             SUPPORTED_CONTEXTS = Collections.unmodifiableMap(supportedContexts);
         }
 
@@ -577,6 +579,13 @@ static Response innerShardOperation(Request request, ScriptService scriptService
                     double result = scoreScript.execute(null);
                     return new Response(result);
                 }, indexService);
+            } else if (scriptContext == UpdateScript.CONTEXT) {
+                return prepareRamIndex(request, (context, leafReaderContext) -> {
+                    UpdateScript.Factory factory = scriptService.compile(request.script, UpdateScript.CONTEXT);
+                    UpdateScript updateScript = factory.newInstance(request.getScript().getParams(), null);
+                    updateScript.execute();
+                    return new Response(null);
+                }, indexService);
             } else {
                 throw new UnsupportedOperationException("unsupported context [" + scriptContext.name + "]");
             }

diff --git a/...s/lang-painless/src/test/java/org/opensearch/painless/action/PainlessExecuteApiTests.java b/...s/lang-painless/src/test/java/org/opensearch/painless/action/PainlessExecuteApiTests.java
@@ -44,6 +44,7 @@
 import org.opensearch.script.ScriptException;
 import org.opensearch.script.ScriptService;
 import org.opensearch.script.ScriptType;
+import org.opensearch.script.UpdateScript;
 import org.opensearch.test.OpenSearchSingleNodeTestCase;
 
 import java.io.IOException;
@@ -142,4 +143,14 @@ public void testScoreExecutionContext() throws IOException {
         assertThat(response.getResult(), equalTo(0.93D));
     }
 
+    public void testUpdateScriptThrowsScriptExceptionWhenDefReturned() throws Exception {
+        ScriptService scriptService = getInstanceFromNode(ScriptService.class);
+        IndexService indexService = createIndex("index", Settings.EMPTY, "doc");
+        Request.ContextSetup contextSetup = new Request.ContextSetup("index", new BytesArray("{\"field\": 3}"), null);
+        contextSetup.setXContentType(XContentType.JSON);
+        Request request = new Request(new Script("def x=1;return x;"), "update", contextSetup);
+        Exception ex = expectThrows(ScriptException.class, () -> innerShardOperation(request, scriptService, indexService));
+        assertThat(ex.getCause().getClass(), equalTo(ClassCastException.class));
+    }
+
 }